Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2A30CF488 for ; Mon, 8 Apr 2013 03:50:32 +0000 (UTC) Received: (qmail 26971 invoked by uid 500); 8 Apr 2013 03:50:31 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 26807 invoked by uid 500); 8 Apr 2013 03:50:30 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 26776 invoked by uid 99); 8 Apr 2013 03:50:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Apr 2013 03:50:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B57BF1C2E0B; Mon, 8 Apr 2013 03:50:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0867642173282215851==" MIME-Version: 1.0 Subject: Re: Review Request: Updated status update manager tests to use new testing abstractions. From: "Vinod Kone" To: "Vinod Kone" Cc: "Benjamin Hindman" , "mesos" Date: Mon, 08 Apr 2013 03:50:26 -0000 Message-ID: <20130408035026.13808.86698@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10309/ X-Sender: "Vinod Kone" References: <20130405174853.23853.8243@reviews.apache.org> In-Reply-To: <20130405174853.23853.8243@reviews.apache.org> Reply-To: "Vinod Kone" --===============0867642173282215851== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10309/#review18768 ----------------------------------------------------------- src/tests/status_update_manager_tests.cpp At some point we should move this up into MesosClusterTest fixture. src/tests/status_update_manager_tests.cpp because we expect it to be None() at the end of the file. src/tests/status_update_manager_tests.cpp thank you - Vinod Kone On April 5, 2013, 5:48 p.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10309/ > ----------------------------------------------------------- > = > (Updated April 5, 2013, 5:48 p.m.) > = > = > Review request for mesos and Vinod Kone. > = > = > Description > ------- > = > This also eliminates the sleep! ;) > = > = > Diffs > ----- > = > src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62= 584826a4e5e = > = > Diff: https://reviews.apache.org/r/10309/diff/ > = > = > Testing > ------- > = > ./bin/mesos-tests.sh --gtest_filter=3DStatusUpdateManagerTest.* --gtest_r= epeat=3D1000 --gtest_shuffle > = > = > Thanks, > = > Benjamin Hindman > = > --===============0867642173282215851==--