Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E43C8F710 for ; Wed, 3 Apr 2013 19:08:48 +0000 (UTC) Received: (qmail 97657 invoked by uid 500); 3 Apr 2013 19:08:48 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 97545 invoked by uid 500); 3 Apr 2013 19:08:48 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 97535 invoked by uid 99); 3 Apr 2013 19:08:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Apr 2013 19:08:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7DF801C2CD1; Wed, 3 Apr 2013 19:08:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1294691852152435405==" MIME-Version: 1.0 Subject: Re: Review Request: Ignore commented lines in slaves/masters files From: "Andrew Ash" To: "Vinod Kone" Cc: "mesos" , "Andrew Ash" Date: Wed, 03 Apr 2013 19:08:46 -0000 Message-ID: <20130403190846.23853.80955@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrew Ash" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10244/ X-Sender: "Andrew Ash" References: <20130403020018.23853.2833@reviews.apache.org> In-Reply-To: <20130403020018.23853.2833@reviews.apache.org> Reply-To: "Andrew Ash" --===============1294691852152435405== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10244/ ----------------------------------------------------------- (Updated April 3, 2013, 7:08 p.m.) Review request for mesos and Vinod Kone. Changes ------- How does this look? I removed the whitespace stuff from the regex because = I realized it doesn't really add any flexibility -- you really ought to hav= e the # at the start of the line anyway Description ------- Ignore commented lines in slaves/masters files Commented-out lines are those that are prefixed with a hash '#' Diffs (updated) ----- src/deploy/mesos-start-masters.sh.in d9833c39b0c6e9b8e9e1b9757a7486d85268= 8643 = src/deploy/mesos-start-slaves.sh.in 4f33babc7d72119b7bf10d394f5982c65360f= c8b = src/deploy/mesos-stop-masters.sh.in 6800c19bccc4b93b4294b929328495b26d0f4= ca0 = src/deploy/mesos-stop-slaves.sh.in e622eb0e9a23c7c095ccfa4da790c0f2cc8f7f= c5 = Diff: https://reviews.apache.org/r/10244/diff/ Testing ------- Thanks, Andrew Ash --===============1294691852152435405==--