incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mattmann, Chris A (398J)" <>
Subject Re: svn commit: r1471710 - /incubator/mesos/trunk/support/
Date Fri, 26 Apr 2013 03:06:48 GMT
Hi Ben,

Just a general note. I had a total of a few hours to look at this
before you committed it. That really isn't enough time. Typically
projects give folks at least between 24-72 hours to let folks scope
something out (or declare otherwise upfront). Apologies I didn't
get to look at this until now (and I sent in a comment), I've been
underwater in meetings, etc.

But it would be good in the future to allow others to have a chance
to take a look. I see you got 2 ship its (1 from vinod, and another
from benm), which is great, I was on the review too and would have
liked to scope it too before committing.

No biggie, just wanted to raise this b/c it's a community issue,
especially for scaling out the project to diverse committers in
multiple organizations, etc., since they'll need time to review things.


Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA

-----Original Message-----
From: "" <>
Reply-To: "" <>
Date: Wednesday, April 24, 2013 2:52 PM
To: ""
Subject: svn commit: r1471710 - /incubator/mesos/trunk/support/

>Author: benh
>Date: Wed Apr 24 21:52:42 2013
>New Revision: 1471710
>Fixed bug creating SVN tag in
>    incubator/mesos/trunk/support/
>Modified: incubator/mesos/trunk/support/
>--- incubator/mesos/trunk/support/ (original)
>+++ incubator/mesos/trunk/support/ Wed Apr 24 21:52:42 2013
>@@ -60,7 +60,7 @@ echo "${GREEN}Finally, we'll create an S
> MESSAGE="Tag for release-${VERSION}-incubating-RC${CANDIDATE}."
>-git svn branch -n --tag -m ${MESSAGE} \
>+git svn branch --tag -m ${MESSAGE} \
>   release-${VERSION}-incubating-RC${CANDIDATE} || \
>   { echo "${RED}Failed to create SVN tag/branch${NORMAL}"; exit 1; }

View raw message