incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <>
Subject Re: Review Request: Send NoMasterDetectedMessage on session timeout to non-contending detectors. Added a disconnected slave map to the master to track disconnected slaves, in order to disallow slave re-registration after a network partition.
Date Tue, 30 Apr 2013 01:30:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 30, 2013, 1:30 a.m.)

Review request for mesos, Benjamin Hindman and Vinod Kone.


Rebased off trunk.


See above. This is a fix of MESOS-305.

This also fixes MESOS-362.

This addresses bugs MESOS-305 and MESOS-362.

Diffs (updated)

  src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 
  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 4a8aaee5a9970c0dd5cb022f04e48fb308241e20 
  src/master/master.cpp ff2f9546b3e5c885da0a5986606beaca57ba4d5c 
  src/tests/fault_tolerance_tests.cpp 70e2d558af72cc267240042577cf9f0fbfebe6d6 
  src/tests/master_detector_tests.cpp b042d6ffb0c2e58c6c338de2b2534fc6b63f5f08 
  src/tests/zookeeper_tests.cpp 125b16566d5cd59732fef67d80617724ff71433b 



make check

Added tests for the partitioned slave re-registration.
./bin/ --gtest_filter="FaultToleranceTest.PartitionedSlaveReregistration" --verbose
--gtest_break_on_failure --gtest_repeat=3000

Ran into MESOS-406, but otherwise no issues.

Will be adding ZK master detector tests shortly to test that the NoMasterDetectedMessages
are being sent.


Ben Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message