incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <>
Subject Re: Review Request: Send NoMasterDetectedMessage on session timeout to non-contending detectors. Added a disconnected slave map to the master to track disconnected slaves, in order to disallow slave re-registration after a network partition.
Date Fri, 19 Apr 2013 20:55:18 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 19, 2013, 8:55 p.m.)

Review request for mesos, Benjamin Hindman and Vinod Kone.


Vinod's review.


See above. This is a fix of MESOS-305.

This also fixes MESOS-362.

This addresses bugs MESOS-305 and MESOS-362.

Diffs (updated)

  src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 
  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
  src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c 
  src/tests/fault_tolerance_tests.cpp 0348f20a8f4333f7d2f3786c33e55713cbcbcbe0 
  src/tests/master_detector_tests.cpp 980f3c720301b83af668e10f479adb9cce4f0c9f 
  src/tests/zookeeper_tests.cpp 0855f5aee0baef22c4ecbed1b88f14f16bfff532 



make check

Added tests for the partitioned slave re-registration.
./bin/ --gtest_filter="FaultToleranceTest.PartitionedSlaveReregistration" --verbose
--gtest_break_on_failure --gtest_repeat=3000

Ran into MESOS-406, but otherwise no issues.

Will be adding ZK master detector tests shortly to test that the NoMasterDetectedMessages
are being sent.


Ben Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message