incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <>
Subject Re: Review Request: When sending NoMasterDetectedMessage, we need to clear the master sequence number in order to ensure we still send NewMasterDetectedMessage if the master is the same. Otherwise, we can get stuck in a master-less state.
Date Fri, 19 Apr 2013 18:53:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 19, 2013, 6:53 p.m.)

Review request for mesos, Benjamin Hindman and Vinod Kone.


Vinod + rebase.


This is also along the way to fixing MESOS-305.

This fixes a bug where we were not clearing the sequence number when sending a NoMasterDetectedMessage.
As a result, this removes the need for hiding NoMasterDetectedMessages from contending non-leaders.

Diffs (updated)

  src/detector/detector.hpp ed485bd86d2bff1046a234a5776c1081a4136bc5 
  src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 
  src/tests/zookeeper_tests.cpp 0855f5aee0baef22c4ecbed1b88f14f16bfff532 



make check

I'd like to add a test for this, but I don't see how to induce a timedout() call on the ZooKeeperMasterDetectorProcess,
unless I add some plumbing to get a handle to the underlying process. Suggestions?


Ben Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message