incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall" <>
Subject Re: Review Request: Clean up HierarchicalAllocatorProcess code
Date Tue, 16 Apr 2013 21:08:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 16, 2013, 9:08 p.m.)

Review request for mesos and Benjamin Hindman.


Updated to trunk.


There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of
hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This
patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids
to structs containing the appropriate attributes. The patch also introduces an allocator namespace.

Diffs (updated)

  src/local/local.hpp 2633d25 
  src/local/local.cpp f43ab2a 
  src/master/allocator.hpp b68b67d 
  src/master/drf_sorter.hpp 79566cc 
  src/master/drf_sorter.cpp fe31a00 
  src/master/hierarchical_allocator_process.hpp 2422fbd 
  src/master/main.cpp d6e1c73 
  src/master/master.hpp 9776a7c 
  src/master/master.cpp 5b0e8c0 
  src/master/sorter.hpp 73db6b1 
  src/tests/allocator_tests.cpp ca8d4ea 
  src/tests/allocator_zookeeper_tests.cpp 82a498e 
  src/tests/fault_tolerance_tests.cpp 0348f20 
  src/tests/resource_offers_tests.cpp ad3640f 
  src/tests/slave_recovery_tests.cpp 7be332b 
  src/tests/sorter_tests.cpp 61e6038 
  src/tests/utils.hpp b5c577d 
  third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d 



make check


Thomas Marshall

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message