incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall" <>
Subject Re: Review Request: Fixed Allocator Test to use DROP_MESSAGE, FutureArg, moved expectations closer to actions, etc
Date Wed, 10 Apr 2013 18:36:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 10, 2013, 6:36 p.m.)

Review request for mesos and Benjamin Hindman.


Updated to Ben's review.

I also changed all of the resourcesChanged expectations to be WillRepeatedly(DoDefault()).
This is to make the tests more robust since the number of times resourcesChanged might get
called isn't a hard guarantee depending on specifics about the slave and the timing of the
test, and its not something that these tests care about anyways.


See summary.

Additionally, I replaced the MockAllocator in DRFAllocatorTest with a regular Allocator because
the expectations were uninteresting, expectations on calls to the allocator are covered in
other tests, and it just made the test a lot messier.

Diffs (updated)

  src/tests/allocator_tests.cpp 04a8581 



bin/ --gtest_filter=*AllocatorTest* --gtest_repeat=3000 --gtest_break_on_failure


Thomas Marshall

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message