incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <>
Subject Re: Review Request: Added os::sleep which takes a Duration object.
Date Tue, 09 Apr 2013 19:28:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 9, 2013, 7:28 p.m.)

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Addressed bmahler's comments. Added flags -lrt to the linker because calling Stopwatch::now()
from os_tests.cpp caused "undefined reference to `clock_gettime'".


This is part 1.
Part 2 would be to replace sleep() call in Mesos to use os::sleep(). 

This addresses bug MESOS-415.

Diffs (updated)

  third_party/libprocess/ cb7f0d73c6ddc1e75f7a3120858362c56a003aa7 
  third_party/libprocess/third_party/stout/include/stout/os.hpp 5c217836a4a60402945544cba862b4c936ff0f83

  third_party/libprocess/third_party/stout/tests/os_tests.cpp d543b6d585097fbd6ee455d4807f23eb3b532a23


Testing (updated)

Ran make check and
./mesos/build/third_party/libprocess/third_party/stout-tests --gtest_filter="OsTest.sleep"


Jiang Yan Xu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message