Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6D0BF6D5 for ; Fri, 29 Mar 2013 21:47:39 +0000 (UTC) Received: (qmail 89990 invoked by uid 500); 29 Mar 2013 21:47:39 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 89966 invoked by uid 500); 29 Mar 2013 21:47:39 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 89954 invoked by uid 99); 29 Mar 2013 21:47:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Mar 2013 21:47:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE2431C10EA; Fri, 29 Mar 2013 21:47:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5766046813434159827==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed status update manager to create the updates path by itself instead of passing the path from the slave. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Fri, 29 Mar 2013 21:47:37 -0000 Message-ID: <20130329214737.12496.44807@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10142/ X-Sender: "Vinod Kone" References: <20130326221802.12538.12492@reviews.apache.org> In-Reply-To: <20130326221802.12538.12492@reviews.apache.org> Reply-To: "Vinod Kone" --===============5766046813434159827== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10142/ ----------------------------------------------------------- (Updated March 29, 2013, 9:47 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- rebased off trunk. Description ------- This is based off https://reviews.apache.org/r/10112. Also fixed TODOs and other misc stuff from the above review. Diffs (updated) ----- src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 = src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 = src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa = src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0= d24 = src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd6= 62a = src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252 = Diff: https://reviews.apache.org/r/10142/diff/ Testing ------- make check Thanks, Vinod Kone --===============5766046813434159827==--