Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A0FA5FA9D for ; Wed, 20 Mar 2013 01:22:41 +0000 (UTC) Received: (qmail 74275 invoked by uid 500); 20 Mar 2013 01:22:41 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 74254 invoked by uid 500); 20 Mar 2013 01:22:41 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 74239 invoked by uid 99); 20 Mar 2013 01:22:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2013 01:22:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 932511C4FAF; Wed, 20 Mar 2013 01:22:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4192140644376862315==" MIME-Version: 1.0 Subject: Re: Review Request: Added a more comprehensive slave recovery test to confirm that the restarted slave can communicate with scheduler, executor and master. From: "Ben Mahler" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Wed, 20 Mar 2013 01:22:40 -0000 Message-ID: <20130320012240.6651.84203@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9992/ X-Sender: "Ben Mahler" References: <20130318040346.6686.38579@reviews.apache.org> In-Reply-To: <20130318040346.6686.38579@reviews.apache.org> Reply-To: "Ben Mahler" --===============4192140644376862315== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9992/#review18136 ----------------------------------------------------------- Ship it! nice test! src/tests/slave_recovery_tests.cpp kill \n - Ben Mahler On March 18, 2013, 4:03 a.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9992/ > ----------------------------------------------------------- > = > (Updated March 18, 2013, 4:03 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > Also cleaned up some slave recovery tests. > = > = > Diffs > ----- > = > src/sched/sched.cpp 960f68bfd6398dc08dc00b9b9ca55b9b2492114e = > src/tests/slave_recovery_tests.cpp 63721c5befe212e1aa559bf5a6e7d34ffce2= 8d4f = > = > Diff: https://reviews.apache.org/r/9992/diff/ > = > = > Testing > ------- > = > make check. > = > = > Thanks, > = > Vinod Kone > = > --===============4192140644376862315==--