Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2342941612586537168=="
MIME-Version: 1.0
Subject: Re: Review Request: AllocatorTest refactor for consistency
From: "Thomas Marshall" <twm378@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>
Cc: "Thomas Marshall" <twm378@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Fri, 15 Mar 2013 22:06:28 -0000
Message-ID: <20130315220628.1180.79774@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Thomas Marshall" <noreply@reviews.apache.org>
References: <20130212020635.21380.89642@reviews.apache.org>
In-Reply-To: <20130212020635.21380.89642@reviews.apache.org>
Reply-To: "Thomas Marshall" <twm378@gmail.com>

--===============2342941612586537168==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9407/
-----------------------------------------------------------

(Updated March 15, 2013, 10:06 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Added a bunch of comments explaining the tests. There is still no change in=
 functionality, so it should be very easy to review and commit.


Description
-------

Refactor of the AllocatorTests so that all Triggers use the -Call conventio=
n.

Also removes the code for checkResources which was removed from use in a pr=
evious patch.

This used to be part of the static allocator review, but has been separated=
 out to make reviewing easier.


Diffs (updated)
-----

  src/tests/allocator_tests.cpp b953cd1 =

  src/tests/allocator_zookeeper_tests.cpp 3f70202 =


Diff: https://reviews.apache.org/r/9407/diff/


Testing
-------

make check


Thanks,

Thomas Marshall


--===============2342941612586537168==--