Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A771FE9AC for ; Fri, 8 Mar 2013 20:09:22 +0000 (UTC) Received: (qmail 7293 invoked by uid 500); 8 Mar 2013 20:09:22 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 7270 invoked by uid 500); 8 Mar 2013 20:09:22 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 7259 invoked by uid 99); 8 Mar 2013 20:09:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2013 20:09:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ACAAF1C800F; Fri, 8 Mar 2013 20:09:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7029085985419372779==" MIME-Version: 1.0 Subject: Re: Review Request: Added child process monitoring to process based isolation module. From: "Vinod Kone" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 08 Mar 2013 20:09:13 -0000 Message-ID: <20130308200913.27098.45301@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9795/ X-Sender: "Vinod Kone" References: <20130307182549.27129.5339@reviews.apache.org> In-Reply-To: <20130307182549.27129.5339@reviews.apache.org> Reply-To: "Vinod Kone" --===============7029085985419372779== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 7, 2013, 6:25 p.m., Vinod Kone wrote: > > src/slave/process_based_isolation_module.cpp, line 332 > > > > > > I think it makes more sense to return an error here instead of retu= rning a wrong value to the user! > = > Ben Mahler wrote: > I don't think I agree, because gathering all the children, and obtain= ing the status of each children does not happen atomically. Therefore, if t= here are any processes that go away during this time, we can't stat them! M= aybe it's sufficiently rare, but I'd rather get an approximate answer when = this happens, rather than give up, no? > = > Say there are 50 processes, and while we stat, one goes away. I'd rat= her get the usage for the remaining 49 processes than nothing at all. Good point. Makes sense. > On March 7, 2013, 6:25 p.m., Vinod Kone wrote: > > src/slave/process_based_isolation_module.cpp, line 318 > > > > > > s/children/descendants/ > = > Ben Mahler wrote: > I think it's clear that it's recursive children, no? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9795/#review17556 ----------------------------------------------------------- On March 8, 2013, 2:27 a.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9795/ > ----------------------------------------------------------- > = > (Updated March 8, 2013, 2:27 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > See subject. > = > = > This addresses bug MESOS-370. > https://issues.apache.org/jira/browse/MESOS-370 > = > = > Diffs > ----- > = > src/slave/process_based_isolation_module.cpp ff98d105af675dfc66070feaa4= 3b42c1aa438fd8 = > = > Diff: https://reviews.apache.org/r/9795/diff/ > = > = > Testing > ------- > = > make check and added tests in a subsequent review > = > = > Thanks, > = > Ben Mahler > = > --===============7029085985419372779==--