Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EFC5E3CB for ; Thu, 7 Mar 2013 07:30:02 +0000 (UTC) Received: (qmail 41128 invoked by uid 500); 7 Mar 2013 07:30:01 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 41091 invoked by uid 500); 7 Mar 2013 07:30:00 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 41058 invoked by uid 99); 7 Mar 2013 07:30:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Mar 2013 07:30:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 95F851C7EDC; Thu, 7 Mar 2013 07:29:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4011519992582119632==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed os::cpus and made os::memory work for OSX. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Thu, 07 Mar 2013 07:29:51 -0000 Message-ID: <20130307072951.27098.58343@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9793/ X-Sender: "Benjamin Hindman" References: <20130307031524.27098.67949@reviews.apache.org> In-Reply-To: <20130307031524.27098.67949@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============4011519992582119632== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9793/#review17520 ----------------------------------------------------------- Ship it! third_party/libprocess/third_party/stout/include/stout/os.hpp s/len/length? third_party/libprocess/third_party/stout/include/stout/os.hpp To make 2 more readable I sometimes will pull out a const size_t NAME_S= IZE above and use that. - Benjamin Hindman On March 7, 2013, 3:15 a.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9793/ > ----------------------------------------------------------- > = > (Updated March 7, 2013, 3:15 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > See description. > = > = > Diffs > ----- > = > third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb9= 5b69684c899e04ca79a1ad8eb11b2b8 = > = > Diff: https://reviews.apache.org/r/9793/diff/ > = > = > Testing > ------- > = > Tested manually, I will be splitting apart the monolithic stout tests in = another review chain. > = > = > Thanks, > = > Ben Mahler > = > --===============4011519992582119632==--