Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 18250D559 for ; Tue, 5 Mar 2013 16:23:51 +0000 (UTC) Received: (qmail 87489 invoked by uid 500); 5 Mar 2013 16:23:51 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 87339 invoked by uid 500); 5 Mar 2013 16:23:50 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 87269 invoked by uid 99); 5 Mar 2013 16:23:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2013 16:23:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A52531C7D2D; Tue, 5 Mar 2013 16:23:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4950418526543821109==" MIME-Version: 1.0 Subject: Re: Review Request: More user-friendly cgroups OOM messages. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Tue, 05 Mar 2013 16:23:40 -0000 Message-ID: <20130305162340.27098.48975@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9121/ X-Sender: "Benjamin Hindman" References: <20130302220846.17206.39284@reviews.apache.org> In-Reply-To: <20130302220846.17206.39284@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============4950418526543821109== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9121/#review17401 ----------------------------------------------------------- Ship it! src/slave/cgroups_isolation_module.cpp I think we've been putting cgroup file names in single quotes, i.e., 'm= emory.limit_in_bytes' (below too for 'memory.usage_in_bytes'). - Benjamin Hindman On March 2, 2013, 10:08 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9121/ > ----------------------------------------------------------- > = > (Updated March 2, 2013, 10:08 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > This is to make the OOM messages friendlier to the end-users of mesos. > = > = > Diffs > ----- > = > src/slave/cgroups_isolation_module.cpp a779de80d13c67e507d7d2ee788fcdaa= 5e71daca = > = > Diff: https://reviews.apache.org/r/9121/diff/ > = > = > Testing > ------- > = > make check > = > ran balloon framework to verify OOM messages: > = > I0128 19:50:11.577399 49752 hierarchical_allocator_process.hpp:542] Recov= ered mem=3D32 (total allocatable: cpus=3D1; mem=3D32) on slave 201301281950= -2081170186-5432-49731-0 from framework 201301281950-2081170186-5432-49731-= 0000 > Task in state TASK_FAILED > Reason: Memory limit exceeded: Requested: 96MB Used: 96MB > = > MEMORY STATISTICS: = > cache 249856 > rss 100413440 > mapped_file 24576 > pgpgin 7872 > pgpgout 6802 > inactive_anon 0 > active_anon 1761280 > inactive_file 192512 > active_file 57344 > unevictable 98652160 > hierarchical_memory_limit 100663296 > total_cache 249856 > total_rss 100413440 > total_mapped_file 24576 > total_pgpgin 7872 > total_pgpgout 6802 > total_inactive_anon 0 > total_active_anon 1761280 > total_inactive_file 192512 > total_active_file 57344 > total_unevictable 98652160 > = > = > Thanks, > = > Ben Mahler > = > --===============4950418526543821109==--