Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 568ADE853 for ; Fri, 1 Mar 2013 23:10:38 +0000 (UTC) Received: (qmail 59446 invoked by uid 500); 1 Mar 2013 23:10:38 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 59384 invoked by uid 500); 1 Mar 2013 23:10:38 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 59368 invoked by uid 99); 1 Mar 2013 23:10:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Mar 2013 23:10:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CB3221C7B6B; Fri, 1 Mar 2013 23:10:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4655362797358119311==" MIME-Version: 1.0 Subject: Re: Review Request: Initial support for CPU limits via CFS Bandwidth Control. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" , "Vinod Kone" Cc: "David Mackey" , "mesos" Date: Fri, 01 Mar 2013 23:10:29 -0000 Message-ID: <20130301231029.17326.58532@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9464/ X-Sender: "Vinod Kone" References: <20130301212422.9277.76729@reviews.apache.org> In-Reply-To: <20130301212422.9277.76729@reviews.apache.org> Reply-To: "Vinod Kone" --===============4655362797358119311== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9464/#review17274 ----------------------------------------------------------- src/slave/cgroups_isolation_module.cpp period at the end. src/slave/cgroups_isolation_module.cpp s/, your/. Your/ ? src/slave/cgroups_isolation_module.cpp quotes around cfsChanged. src/slave/cgroups_isolation_module.cpp Considering mesos is responsible for manipulating resources, this shoul= d be a CHECK. src/slave/cgroups_isolation_module.cpp Move these down to where they are used (line #815) - Vinod Kone On March 1, 2013, 9:24 p.m., David Mackey wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9464/ > ----------------------------------------------------------- > = > (Updated March 1, 2013, 9:24 p.m.) > = > = > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > = > = > Description > ------- > = > Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroup= s. > = > CFS is unique relative to existing Mesos cgroups support in that it is a = "subfeature" of an already supported cgroups subsystem, cpu. Also, there ar= e two "tunables" for configuring CFS bandwidth limiting. > = > There are 4 approaches one could take: > 1) Use the CFS bandwidth limiting if the feature is present > 2) Expose as separate flag, eg "cpu,cfs,memory,freezer" > 3) Add feature flag support to subsystems via an additional delimiter, eg= "cpu+cfs,memory,freezer". = > 4) Add an additional control flag via some other means > = > Option 2's downside breaks the 1:1 mapping between cgroups subsystems and= a cgroups resource flag. > Option 3's downside is it greatly increases complexity of parsing cgroups= subsystem flags. > = > This diff takes option 1. = > = > = > This addresses bug MESOS-315. > https://issues.apache.org/jira/browse/MESOS-315 > = > = > Diffs > ----- > = > src/slave/cgroups_isolation_module.hpp a04fc46 = > src/slave/cgroups_isolation_module.cpp a779de8 = > src/slave/flags.hpp d4aa045 = > = > Diff: https://reviews.apache.org/r/9464/diff/ > = > = > Testing > ------- > = > make check + additional testing > = > = > Thanks, > = > David Mackey > = > --===============4655362797358119311==--