incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Mackey" <>
Subject Re: Review Request: Initial support for CPU limits via CFS Bandwidth Control.
Date Tue, 26 Mar 2013 23:44:03 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 26, 2013, 11:44 p.m.)

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Rebased off trunk and changed flag behavior to be an explicit flag instead of a "feature list."
Nested handlers remain.


Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups.

CFS is unique relative to existing Mesos cgroups support in that it is a "subfeature" of an
already supported cgroups subsystem, cpu. Also, there are two "tunables" for configuring CFS
bandwidth limiting.

There are 4 approaches one could take:
1) Use the CFS bandwidth limiting if the feature is present
2) Expose as separate flag, eg "cpu,cfs,memory,freezer"
3) Add feature flag support to subsystems via an additional delimiter, eg "cpu+cfs,memory,freezer".

4) Add an additional control flag via some other means

Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a cgroups resource
Option 3's downside is it greatly increases complexity of parsing cgroups subsystem flags.

This diff takes option 1. 

This addresses bug MESOS-315.

Diffs (updated)

  src/slave/cgroups_isolator.hpp 1732c4e 
  src/slave/cgroups_isolator.cpp ebc2843 
  src/slave/flags.hpp 95969ae 
  third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp a8feabd 



make check + additional testing


David Mackey

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message