incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall" <>
Subject Review Request: Fixes the flaky AllocatorTest/ResourcesUnused test
Date Mon, 18 Mar 2013 21:40:51 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


In the ResourcesUnused test, a framework receives an offer and then launches a task with it
that uses less than the entire offer, to check that the unused resources are being returned
and reoffered correctly. Since we don't care that the task is actually launched by the executor,
just that the master processes the task launching, the test was written under the assumption
that it would exit before the executor was registered and received the launchTask call. This
doesn't always happen, though, so the test was sometimes failing.

This patch adds in expectations on the executor for the registered and launchTask calls, though
since we still don't care whether or not they actually happen they are both cardinality AtMost(1).

This addresses bug MESOS-378.


  src/tests/allocator_tests.cpp 4ae8bfd 



make check


Thomas Marshall

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message