incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <>
Subject Re: Review Request: Added fixtures to enable templatized isolation module tests and fixed a bug in cgroups isolation module.
Date Tue, 12 Mar 2013 22:21:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 12, 2013, 10:21 p.m.)

Review request for mesos, Benjamin Hindman and Ben Mahler.


Moar refactoring. Hopefully this is much cleaner.

--> Moved the cgroups hierarchies back to cgroups_tests.

--> Added 3 more functions to cgroups namespace, that I used in test fixtures.


With the new fixtures, one can implement a typed test, for isolation modules, as follows.

template <typename T>
class SlaveRecoveryTest : public IsolationTest<T>
 T isolationModule;

Diffs (updated)

  src/linux/cgroups.hpp 56c6eb7ea130acd951eabdb42dafae4f2cdcff4d 
  src/linux/cgroups.cpp 480ae228a1365afa60c9f88c1f31f48e3a5eb294 
  src/slave/cgroups_isolation_module.hpp 11244802b3210ef1a6900b978faf8bbcaa00266c 
  src/slave/cgroups_isolation_module.cpp 9395d9cd6cf2ac7a720480b778836eb1d704e00d 
  src/tests/cgroups_tests.cpp 65c2bfaec1dd5adc879a206aa97592ae7f0c0074 
  src/tests/utils.hpp d3efa58ef62383af9eb051b23feb950ba6a4f4e3 



make check


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message