incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall" <>
Subject Review Request: Fixes the flaky AllocatorTests.TaskFinished unit test
Date Tue, 12 Mar 2013 21:46:55 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Benjamin Hindman.


In the TaskFinished unit test, TestingIsolationModule::resourcesChanged should be called three
times - once each for the two tasks that are launched, and once for the task that is killed.
The way the test was written before, we were only expecting 2 calls, and since the call resulting
from the task being killed usually didn't happen before the test was shut down this worked
most but not all of the time, causing occasional flakiness. This patch changes it to expect
3 calls and adds a trigger so that we wait until the third call happens before shutting down
the test.

This addresses bug MESOS-386.


  src/tests/allocator_tests.cpp b953cd1 



make check


Thomas Marshall

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message