incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <>
Subject Re: Review Request: Refactored cgroups tests and made root cgroup used by cgroups isolation module configurable.
Date Fri, 08 Mar 2013 19:45:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 8, 2013, 7:45 p.m.)

Review request for mesos, Benjamin Hindman and Ben Mahler.


Changed some CHECK_SOMEs to EXITs and incorporated BenM's changes from


Pulled out some cgroups test fixtures into test utils, and made them generic, so that they
can be re-used by other tests.

Also the root cgroup can be configured via flag, helping cgroups isolation module related
tests to use a different cgroup (e.g. "mesos_tests").

NOTE: This is based of my earlier cgroups review:

Diffs (updated)

  src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 
  src/slave/flags.hpp 9cd436cae5772b906b3566eb1f344904d5894214 
  src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2 
  src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541 



sudo GLOG_v=1 ./bin/ --gtest_filter="*Cgroups*" --verbose


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message