Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 465F2EF8D for ; Tue, 26 Feb 2013 20:22:10 +0000 (UTC) Received: (qmail 69227 invoked by uid 500); 26 Feb 2013 20:22:10 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 69108 invoked by uid 500); 26 Feb 2013 20:22:10 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 69097 invoked by uid 99); 26 Feb 2013 20:22:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Feb 2013 20:22:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 29B351C7314; Tue, 26 Feb 2013 20:22:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3650765578820398509==" MIME-Version: 1.0 Subject: Review Request: Made stout independent of libprocess and Mesos. From: "Benjamin Hindman" To: "Vinod Kone" , "Ben Mahler" Cc: "mesos" , "Benjamin Hindman" Date: Tue, 26 Feb 2013 20:22:02 -0000 Message-ID: <20130226202202.1280.29553@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9631/ X-Sender: "Benjamin Hindman" Reply-To: "Benjamin Hindman" --===============3650765578820398509== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9631/ ----------------------------------------------------------- Review request for mesos, Vinod Kone and Ben Mahler. Description ------- For now, I decided to eliminate building the stout tests _within_ stout. In= stead, the README explains how to build the stout tests and we do so in lib= process in order to make sure they actually get run. It probably makes sens= e to actually build the tests in stout itself in the future but (a) the imp= ortant thing is getting stout independent and (b) the tests still get run w= hen we build Mesos and (c) it's a header only library anyway so most people= will just want to embed the library and not care about ever having to call= make on it (if they call make on it for anything it will be because it is = being embedded within a distribution as a subdirectory and the outermost pa= ckage did a 'make dist'). Diffs ----- Makefile.am 746de0dfda036bf85e04a5fa18711b3ea09e2d3c = src/Makefile.am 8c74525ff6381b6d8624622a758b792fd631cd8c = src/tests/assert.hpp f10f63ae9c2d783fb8ef19ba523eb8144b33d292 = src/tests/fs_tests.cpp 81a10b501c35695989d4070099d422f281d91e89 = src/tests/gc_tests.cpp 411bcc09b28a2543ecd3d083839e10844e8a9939 = src/tests/stout_tests.cpp 6d01330f7009ec94b3b11c89c562eceed4515a3e = src/tests/utils.hpp 4600c2f6e0ceabd6a38f8bb762da314b795c23a0 = third_party/Makefile.am fb8984e8d1bbc527683eec37a1a65cb85fb28fc1 = third_party/libprocess/Makefile.am e5b2ba410744f62d1b2ab47e79a8d0a19eb573= 70 = third_party/libprocess/configure.ac 86b938564078702a62a11105b47a45bedd992= 572 = third_party/libprocess/include/process/gtest.hpp PRE-CREATION = third_party/libprocess/include/stout/cache.hpp 653507c5f1293acb929d2ffa33= 738fd830541c84 = third_party/libprocess/include/stout/duration.hpp 17d2d316fcd994212f41577= f54c112e41e061bc6 = third_party/libprocess/include/stout/error.hpp 97a5cec8988de2cabf158b80a1= d34b19ea4faadf = third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3beea= d822fdcb19981 = third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada20841= 523c4e5c7ffad4 = third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba600= c50f81839e9b4c91 = third_party/libprocess/include/stout/format.hpp 71b5986bc8da1a6a128067a6f= c4b48425c9e49e7 = third_party/libprocess/include/stout/fs.hpp 4dedf5522d62b920b859a0a309857= 1665496ca5c = third_party/libprocess/include/stout/gzip.hpp ef36f1bc128d83ce4347aeb38c6= 70ea1c718daba = third_party/libprocess/include/stout/hashmap.hpp 796cb505fe538d5f65c0f8ea= 1fa827155f2bb2c1 = third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a80977d= 5c6006f1a45cb4d0 = third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa9f= 51f0014a8c5d3 = third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a97= c5440190a015c45 = third_party/libprocess/include/stout/multihashmap.hpp a8feabd24dce017ee61= f10d3f474ba0db19f2aef = third_party/libprocess/include/stout/net.hpp 1c5f88aa94dd30a14271809410b7= d5f6c9ce2be4 = third_party/libprocess/include/stout/none.hpp ea8e0f52f11df87d71150f21b31= 8447662e1e986 = third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f188= b100576b340ab71a = third_party/libprocess/include/stout/numify.hpp d23e23832fca319bb85a831ff= 56d54fa2f41e422 = third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da807= 1b1a8d168c872ca = third_party/libprocess/include/stout/os.hpp 32638ee273492550491b85223cda8= e7a5bde7fa5 = third_party/libprocess/include/stout/owned.hpp 3433f50f6518a42f5eb3bfedc4= 1a22f0efa24988 = third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d005= 132634c7912e0 = third_party/libprocess/include/stout/protobuf.hpp eb79e7b0a0cda6ef2086ab0= 3aa2ba71e686cef38 = third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8f5= 01135e67804c335 = third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e16= e9bf49a3ef235f19d5 = third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc56= 59b166e92380be0bca = third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2c= eec8a812556df7dd = third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0ee7= 0abeca322fab = third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d914595= 25739edd53d150 = third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af398805= ada0a8ba7d14c = third_party/libprocess/third_party/Makefile.am 150b0d8ad16c5ea3de3a96290d= 0859bc1a192a15 = third_party/libprocess/third_party/stout/LICENSE PRE-CREATION = third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION = third_party/libprocess/third_party/stout/README PRE-CREATION = third_party/libprocess/third_party/stout/bootstrap PRE-CREATION = third_party/libprocess/third_party/stout/configure.ac PRE-CREATION = third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CREA= TION = third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE-C= REATION = third_party/libprocess/third_party/stout/include/stout/error.hpp PRE-CREA= TION = third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CREAT= ION = third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CREA= TION = third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-CR= EATION = third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-CRE= ATION = third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREATIO= N = third_party/libprocess/third_party/stout/include/stout/gtest.hpp PRE-CREA= TION = third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CREAT= ION = third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-CR= EATION = third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-CR= EATION = third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CREAT= ION = third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-CRE= ATION = third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp P= RE-CREATION = third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREATI= ON = third_party/libprocess/third_party/stout/include/stout/none.hpp PRE-CREAT= ION = third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-CR= EATION = third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-CRE= ATION = third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-CRE= ATION = third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREATIO= N = third_party/libprocess/third_party/stout/include/stout/owned.hpp PRE-CREA= TION = third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CREAT= ION = third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE-C= REATION = third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-CRE= ATION = third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PRE-= CREATION = third_party/libprocess/third_party/stout/include/stout/stringify.hpp PRE-= CREATION = third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-CR= EATION = third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREATI= ON = third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CREA= TION = third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CREAT= ION = third_party/libprocess/third_party/stout/install-sh PRE-CREATION = third_party/libprocess/third_party/stout/m4/acx_pthread.m4 PRE-CREATION = third_party/libprocess/third_party/stout/tests/tests.cpp PRE-CREATION = Diff: https://reviews.apache.org/r/9631/diff/ Testing ------- make distcheck Thanks, Benjamin Hindman --===============3650765578820398509==--