Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6653E60A for ; Mon, 25 Feb 2013 22:02:20 +0000 (UTC) Received: (qmail 42245 invoked by uid 500); 25 Feb 2013 22:02:20 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 42211 invoked by uid 500); 25 Feb 2013 22:02:20 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 42200 invoked by uid 99); 25 Feb 2013 22:02:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Feb 2013 22:02:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 844001C79EA; Mon, 25 Feb 2013 22:02:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0656177486145195088==" MIME-Version: 1.0 Subject: Re: Review Request: Standalone stout. Split apart the stout tests into separate files. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Mon, 25 Feb 2013 22:02:12 -0000 Message-ID: <20130225220212.1281.15346@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8796/ X-Sender: "Benjamin Hindman" References: <20130201235641.24984.63277@reviews.apache.org> In-Reply-To: <20130201235641.24984.63277@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============0656177486145195088== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8796/#review17060 ----------------------------------------------------------- third_party/libprocess/Makefile.am These shouldn't be included in both libprocess and stout ... that would= produce a weird distribution. - Benjamin Hindman On Feb. 1, 2013, 11:56 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8796/ > ----------------------------------------------------------- > = > (Updated Feb. 1, 2013, 11:56 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > This is part 5 of my refactoring to pull apart libprocess / stout tests. > = > This is the final part, which pulls apart the stout tests. > This makes it easier to spot where our test coverage is insufficient. > There are no real diffs on these *tests.cpp files, since I just pulled th= e contents of stout_tests.cpp apart. > = > = > Diffs > ----- > = > src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 = > src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe7203= 83 = > third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c= 3325 = > third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a946366= 8fc75 = > third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014b= da153d557d058396 = > third_party/libprocess/include/stout/duration.hpp caf7ce42b34dfb74206d1= f10aafabaaec47e7dfc = > third_party/libprocess/include/stout/exit.hpp 3da01123eb37d3aa8b0d2c3be= ead822fdcb19981 = > third_party/libprocess/include/stout/fatal.hpp eabee3ef053727c664ada208= 41523c4e5c7ffad4 = > third_party/libprocess/include/stout/foreach.hpp 0afe285b310fde673f9ba6= 00c50f81839e9b4c91 = > third_party/libprocess/include/stout/format.hpp fc349903d31d6e31a8147e3= a6be87b37698f28f0 = > third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8= bcec46b0bd26d = > third_party/libprocess/include/stout/gzip.hpp 6ff1288683a0d3b05098c7729= 45cc2a8b73f8b01 = > third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1= cdd1682d976af408b4 = > third_party/libprocess/include/stout/hashset.hpp f584545976edaa7d6a8097= 7d5c6006f1a45cb4d0 = > third_party/libprocess/include/stout/json.hpp e2cd4f21cf4a12dbce0748dfa= 9f51f0014a8c5d3 = > third_party/libprocess/include/stout/lambda.hpp d493353838d95eb2698892a= 97c5440190a015c45 = > third_party/libprocess/include/stout/multihashmap.hpp 6d324d43d19b26b0c= fe87faa2e991bf074b38d50 = > third_party/libprocess/include/stout/net.hpp 1909046017da005a5e7c64d525= bb3c741d5ad436 = > third_party/libprocess/include/stout/nothing.hpp c11a0102dbf646410747f1= 88b100576b340ab71a = > third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a= 2d159984f5bbc6b73 = > third_party/libprocess/include/stout/option.hpp d19127cd447f26a44ed0da8= 071b1a8d168c872ca = > third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef88= 98a6efd778514 = > third_party/libprocess/include/stout/path.hpp fda4e0425aca4e973758c45d0= 05132634c7912e0 = > third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1= a922353f0ce52e458df = > third_party/libprocess/include/stout/result.hpp 3326da0042017e76154f4c8= f501135e67804c335 = > third_party/libprocess/include/stout/stopwatch.hpp bcff8c63e3988f4b063e= 16e9bf49a3ef235f19d5 = > third_party/libprocess/include/stout/stringify.hpp 136316d2543396254fbc= 5659b166e92380be0bca = > third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e= 2ceec8a812556df7dd = > third_party/libprocess/include/stout/try.hpp 787bffd2f619a7a5202b349e0e= e70abeca322fab = > third_party/libprocess/include/stout/utils.hpp 0f4bba2ce23a1a03a12d9145= 9525739edd53d150 = > third_party/libprocess/include/stout/uuid.hpp c6c290d2aaa5744ef71af3988= 05ada0a8ba7d14c = > third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION = > third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf534= 3c4b3c3c9e47bf0c = > third_party/libprocess/third_party/stout/LICENSE PRE-CREATION = > third_party/libprocess/third_party/stout/Makefile.am PRE-CREATION = > third_party/libprocess/third_party/stout/README PRE-CREATION = > third_party/libprocess/third_party/stout/bootstrap PRE-CREATION = > third_party/libprocess/third_party/stout/configure.ac PRE-CREATION = > third_party/libprocess/third_party/stout/include/stout/cache.hpp PRE-CR= EATION = > third_party/libprocess/third_party/stout/include/stout/duration.hpp PRE= -CREATION = > third_party/libprocess/third_party/stout/include/stout/exit.hpp PRE-CRE= ATION = > third_party/libprocess/third_party/stout/include/stout/fatal.hpp PRE-CR= EATION = > third_party/libprocess/third_party/stout/include/stout/foreach.hpp PRE-= CREATION = > third_party/libprocess/third_party/stout/include/stout/format.hpp PRE-C= REATION = > third_party/libprocess/third_party/stout/include/stout/fs.hpp PRE-CREAT= ION = > third_party/libprocess/third_party/stout/include/stout/gzip.hpp PRE-CRE= ATION = > third_party/libprocess/third_party/stout/include/stout/hashmap.hpp PRE-= CREATION = > third_party/libprocess/third_party/stout/include/stout/hashset.hpp PRE-= CREATION = > third_party/libprocess/third_party/stout/include/stout/json.hpp PRE-CRE= ATION = > third_party/libprocess/third_party/stout/include/stout/lambda.hpp PRE-C= REATION = > third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp= PRE-CREATION = > third_party/libprocess/third_party/stout/include/stout/net.hpp PRE-CREA= TION = > third_party/libprocess/third_party/stout/include/stout/nothing.hpp PRE-= CREATION = > third_party/libprocess/third_party/stout/include/stout/numify.hpp PRE-C= REATION = > third_party/libprocess/third_party/stout/include/stout/option.hpp PRE-C= REATION = > third_party/libprocess/third_party/stout/include/stout/os.hpp PRE-CREAT= ION = > third_party/libprocess/third_party/stout/include/stout/path.hpp PRE-CRE= ATION = > third_party/libprocess/third_party/stout/include/stout/protobuf.hpp PRE= -CREATION = > third_party/libprocess/third_party/stout/include/stout/result.hpp PRE-C= REATION = > third_party/libprocess/third_party/stout/include/stout/stopwatch.hpp PR= E-CREATION = > third_party/libprocess/third_party/stout/include/stout/stringify.hpp PR= E-CREATION = > third_party/libprocess/third_party/stout/include/stout/strings.hpp PRE-= CREATION = > third_party/libprocess/third_party/stout/include/stout/try.hpp PRE-CREA= TION = > third_party/libprocess/third_party/stout/include/stout/utils.hpp PRE-CR= EATION = > third_party/libprocess/third_party/stout/include/stout/uuid.hpp PRE-CRE= ATION = > third_party/libprocess/third_party/stout/m4/libtool.m4 PRE-CREATION = > third_party/libprocess/third_party/stout/m4/ltoptions.m4 PRE-CREATION = > third_party/libprocess/third_party/stout/m4/ltsugar.m4 PRE-CREATION = > third_party/libprocess/third_party/stout/m4/ltversion.m4 PRE-CREATION = > third_party/libprocess/third_party/stout/m4/lt~obsolete.m4 PRE-CREATION = > third_party/libprocess/third_party/stout/tests/assert.hpp PRE-CREATION = > third_party/libprocess/third_party/stout/tests/duration_tests.cpp PRE-C= REATION = > third_party/libprocess/third_party/stout/tests/gzip_tests.cpp PRE-CREAT= ION = > third_party/libprocess/third_party/stout/tests/hashset_tests.cpp PRE-CR= EATION = > third_party/libprocess/third_party/stout/tests/json_tests.cpp PRE-CREAT= ION = > third_party/libprocess/third_party/stout/tests/main.cpp PRE-CREATION = > third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp P= RE-CREATION = > third_party/libprocess/third_party/stout/tests/os_tests.cpp PRE-CREATIO= N = > third_party/libprocess/third_party/stout/tests/strings_tests.cpp PRE-CR= EATION = > third_party/libprocess/third_party/stout/tests/uuid_tests.cpp PRE-CREAT= ION = > third_party/libprocess/third_party/stout/third_party/Makefile.am PRE-CR= EATION = > third_party/libprocess/third_party/stout/third_party/boost-1.51.0.tar.g= z PRE-CREATION = > third_party/libprocess/third_party/stout/third_party/glog-0.3.1.tar.gz = PRE-CREATION = > third_party/libprocess/third_party/stout/third_party/gmock-1.6.0.tar.gz= PRE-CREATION = > third_party/libprocess/third_party/stout/third_party/versions.am PRE-CR= EATION = > = > Diff: https://reviews.apache.org/r/8796/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Ben Mahler > = > --===============0656177486145195088==--