Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3605693344258987266=="
MIME-Version: 1.0
Subject: Re: Review Request: Initial support for CPU limits via CFS Bandwidth
 Control.
From: "David Mackey" <tdmackey@booleanhaiku.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "David Mackey" <tdmackey@booleanhaiku.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Mon, 18 Feb 2013 23:51:45 -0000
Message-ID: <20130218235145.18986.71963@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "David Mackey" <noreply@reviews.apache.org>
References: <20130215064215.21521.79541@reviews.apache.org>
In-Reply-To: <20130215064215.21521.79541@reviews.apache.org>
Reply-To: "David Mackey" <tdmackey@booleanhaiku.com>

--===============3605693344258987266==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9464/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 11:51 p.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

Updated per BenM's comments.


Description
-------

Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups.

CFS is unique relative to existing Mesos cgroups support in that it is a "s=
ubfeature" of an already supported cgroups subsystem, cpu. Also, there are =
two "tunables" for configuring CFS bandwidth limiting.

There are 4 approaches one could take:
1) Use the CFS bandwidth limiting if the feature is present
2) Expose as separate flag, eg "cpu,cfs,memory,freezer"
3) Add feature flag support to subsystems via an additional delimiter, eg "=
cpu+cfs,memory,freezer". =

4) Add an additional control flag via some other means

Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a=
 cgroups resource flag.
Option 3's downside is it greatly increases complexity of parsing cgroups s=
ubsystem flags.

This diff takes option 1. =


This addresses bug MESOS-315.
    https://issues.apache.org/jira/browse/MESOS-315


Diffs (updated)
-----

  src/slave/cgroups_isolation_module.cpp 14f549e =


Diff: https://reviews.apache.org/r/9464/diff/


Testing
-------

make check + additional testing


Thanks,

David Mackey


--===============3605693344258987266==--