Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6750BD683 for ; Fri, 8 Feb 2013 20:22:03 +0000 (UTC) Received: (qmail 44795 invoked by uid 500); 8 Feb 2013 20:22:03 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 44763 invoked by uid 500); 8 Feb 2013 20:22:03 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 44751 invoked by uid 99); 8 Feb 2013 20:22:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Feb 2013 20:22:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F2B41C6FAA; Fri, 8 Feb 2013 20:21:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9135839366833572098==" MIME-Version: 1.0 Subject: Re: Review Request: Refactored all Option::none and Result::none to use None. From: "Vinod Kone" To: "Vinod Kone" , "Ben Mahler" Cc: "Benjamin Hindman" , "mesos" Date: Fri, 08 Feb 2013 20:21:55 -0000 Message-ID: <20130208202155.13218.15184@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/9307/ X-Sender: "Vinod Kone" References: <20130205055746.13218.15435@reviews.apache.org> In-Reply-To: <20130205055746.13218.15435@reviews.apache.org> Reply-To: "Vinod Kone" --===============9135839366833572098== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9307/#review16369 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9307/ > ----------------------------------------------------------- > = > (Updated Feb. 5, 2013, 5:57 a.m.) > = > = > Review request for mesos, Vinod Kone and Ben Mahler. > = > = > Description > ------- > = > See summary. > = > = > Diffs > ----- > = > src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 = > src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd = > src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7c= e46f = > src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 = > src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 = > src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 = > src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 = > src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 = > src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 = > src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b = > src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d = > src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 = > src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c7= 05f = > src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 = > src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d = > src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 = > src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b = > src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 = > src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b40= 2 = > src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 = > src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c = > third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2= b92fcee98166e360f352 = > third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a= 4858961ef471779fd = > third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022= eacacad00bc4d974a8e33c9 = > third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014b= da153d557d058396 = > third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1= cdd1682d976af408b4 = > third_party/libprocess/include/stout/none.hpp PRE-CREATION = > third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a= 2d159984f5bbc6b73 = > third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef88= 98a6efd778514 = > third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1= a922353f0ce52e458df = > third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef7= 6a4e2b23 = > third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f92= 89f0e3d7f2f = > = > Diff: https://reviews.apache.org/r/9307/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Benjamin Hindman > = > --===============9135839366833572098==--