Return-Path: 
 <mesos-dev-return-5513-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 37B9EE8B0
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Wed,  6 Feb 2013 23:52:02 +0000 (UTC)
Received: (qmail 77768 invoked by uid 500); 6 Feb 2013 23:52:02 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 77667 invoked by uid 500); 6 Feb 2013 23:52:02 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 77655 invoked by uid 99); 6 Feb 2013 23:52:02 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2013 23:52:02 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id EBD371C7145;
	Wed,  6 Feb 2013 23:51:54 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============3141015488726669794=="
MIME-Version: 1.0
Subject: Re: Review Request: Fix proxy scheduler build error
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "David Mackey" <tdmackey@booleanhaiku.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Wed, 06 Feb 2013 23:51:54 -0000
Message-ID: <20130206235154.13216.67575@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Vinod Kone" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/9320/
X-Sender: "Vinod Kone" <noreply@reviews.apache.org>
References: <20130206043433.13216.27142@reviews.apache.org>
In-Reply-To: <20130206043433.13216.27142@reviews.apache.org>
Reply-To: "Vinod Kone" <vinodkone@gmail.com>

--===============3141015488726669794==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/#review16225
-----------------------------------------------------------



src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/9320/#comment34676>

    Also, forgot to mention that we intersperse groups of includes with new=
 lines. The convention is as follows
    =

    <c-standard-headers>
    =

    <thirdparty c headers>
    =

    <c++-standard-headers>
    =

    <thirdparty c++ headers>
    =

    "mesos headers"
    =

    NOTE: We further split a group according to the depth of the header pat=
h.
    =

    Example:
    =

    #include <errno.h>
    #include <fts.h>
    #include <signal.h>
    #include <unistd.h>
    =

    #include <sys/syscall.h>
    #include <sys/types.h>
    =

    #include <glog/logging.h>
    =

    #include <fstream>
    #include <list>
    #include <map>
    #include <set>
    #include <sstream>
    #include <string>
    #include <vector>
    =

    #include <process/collect.hpp>
    #include <process/defer.hpp>
    #include <process/delay.hpp>
    #include <process/io.hpp>
    #include <process/process.hpp>
    =

    #include <stout/duration.hpp>
    #include <stout/foreach.hpp>
    #include <stout/lambda.hpp>
    #include <stout/option.hpp>
    #include <stout/os.hpp>
    #include <stout/path.hpp>
    #include <stout/stringify.hpp>
    #include <stout/strings.hpp>
    =

    #include "linux/cgroups.hpp"
    #include "linux/fs.hpp"
    #include "linux/proc.hpp"
    =

    =

    Let me know if you have any questions about this!


- Vinod Kone


On Feb. 6, 2013, 4:34 a.m., David Mackey wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9320/
> -----------------------------------------------------------
> =

> (Updated Feb. 6, 2013, 4:34 a.m.)
> =

> =

> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> =

> =

> Description
> -------
> =

> Python.h is a finicky header file. Include it before iostream.
> =

> =

> This addresses bug MESOS-271.
>     https://issues.apache.org/jira/browse/MESOS-271
> =

> =

> Diffs
> -----
> =

>   src/python/native/proxy_scheduler.cpp 8bf368d =

> =

> Diff: https://reviews.apache.org/r/9320/diff/
> =

> =

> Testing
> -------
> =

> make check passes.
> =

> =

> Thanks,
> =

> David Mackey
> =

>


--===============3141015488726669794==--