incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <>
Subject Re: Review Request: Added ResourceMonitor unit tests.
Date Wed, 27 Feb 2013 02:16:44 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 27, 2013, 2:16 a.m.)

Review request for mesos, Benjamin Hindman and Vinod Kone.


benh + vinod reviews


Ultimately I'd like to be testing even more functionality of the ResourceMonitor:
  1. Check that the data has been published to statistics.
  2. Check that metering is occurring on subsequent resource data (cpu_usage).
  3. Add tests for process based isolation usage.
  4. Add tests for cgroups based isolation usage.

1 and 2 are possible within this change.
3 and 4 are trickier given our current testing setup.

For now, I've done testing locally and a test cluster to ensure the above were working as

Diffs (updated)

  src/ 8c74525ff6381b6d8624622a758b792fd631cd8c 
  src/files/files.hpp ff12c0dc70af107397c499ec605691a8367d0c90 
  src/files/files.cpp 29705dc69921a86a0abd7428f2c5d38c41838301 
  src/slave/monitor.hpp e2ef3bdf6cd5b2718db01184d98d4d29cd5b00c9 
  src/tests/files_tests.cpp 7147b9a6a16a63fe7922bd84bda0539f89c00f5c 
  src/tests/gc_tests.cpp 411bcc09b28a2543ecd3d083839e10844e8a9939 
  src/tests/monitor_tests.cpp PRE-CREATION 
  third_party/libprocess/include/process/http.hpp bee67826485fd77591621af74437bf38c8ce83e1

  third_party/libprocess/src/process.cpp ede0e5563d0811ad661f78072a862b21473763f3 



make check


Ben Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message