incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <>
Subject Re: Review Request: Fix for doing executor setup inside the forked process in cgroups isolation module
Date Sat, 09 Feb 2013 00:05:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 9, 2013, 12:05 a.m.)

Review request for mesos, Benjamin Hindman and Ben Mahler.


No need to re-review. Just uploading a rebased diff for posterity.

Submitting now.


Now, we do the executor setup (fetching etc) inside the forked process but before assigning
the process to its own cgroup.

This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup

This addresses bugs MESOS-262 and MESOS-310.

Diffs (updated)

  src/slave/cgroups_isolation_module.cpp 63cefc3 
  src/slave/process_based_isolation_module.cpp 3d50a4b 



sudo make check


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message