Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8EF7EEB18 for ; Wed, 30 Jan 2013 19:52:33 +0000 (UTC) Received: (qmail 90058 invoked by uid 500); 30 Jan 2013 19:52:33 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 90026 invoked by uid 500); 30 Jan 2013 19:52:33 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 90015 invoked by uid 99); 30 Jan 2013 19:52:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2013 19:52:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C33AD1C6EF7; Wed, 30 Jan 2013 19:52:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7696798277834915731==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed protobuf read / write calls to be POSIX compliant (handle 0, EINTR, and partial reads / writes). From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Wed, 30 Jan 2013 19:52:26 -0000 Message-ID: <20130130195226.24967.81492@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8695/ X-Sender: "Benjamin Hindman" References: <20130116004831.27590.48081@reviews.apache.org> In-Reply-To: <20130116004831.27590.48081@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============7696798277834915731== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8695/#review15876 ----------------------------------------------------------- Ship it! Let's revisit some of the comments I made in future patches. - Benjamin Hindman On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8695/ > ----------------------------------------------------------- > = > (Updated Jan. 16, 2013, 12:48 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > Please review this first: https://reviews.apache.org/r/8694/ > = > All is well in the world again. > = > = > This addresses bug MESOS-319. > https://issues.apache.org/jira/browse/MESOS-319 > = > = > Diffs > ----- > = > src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e = > src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc= 9 = > third_party/libprocess/include/stout/protobuf.hpp 722f67555d8eb8a3fe415= 66e968c0be805c276e0 = > = > Diff: https://reviews.apache.org/r/8695/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Ben Mahler > = > --===============7696798277834915731==--