Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 31D6DDB49 for ; Thu, 20 Dec 2012 17:29:57 +0000 (UTC) Received: (qmail 62800 invoked by uid 500); 20 Dec 2012 17:29:57 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 62757 invoked by uid 500); 20 Dec 2012 17:29:56 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 62742 invoked by uid 99); 20 Dec 2012 17:29:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2012 17:29:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 634001C5B9A; Thu, 20 Dec 2012 17:29:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8805112068019145857==" MIME-Version: 1.0 Subject: Re: Review Request: Encoding JSON strings as ASCII (fix for binary data in JSON strings). From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Thu, 20 Dec 2012 17:29:51 -0000 Message-ID: <20121220172951.20143.69146@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8056/ X-Sender: "Benjamin Hindman" References: <20121219190246.20143.51865@reviews.apache.org> In-Reply-To: <20121219190246.20143.51865@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============8805112068019145857== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8056/#review14761 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Hindman On Dec. 19, 2012, 7:02 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8056/ > ----------------------------------------------------------- > = > (Updated Dec. 19, 2012, 7:02 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > At twitter, we had an executor using binary data in the TaskInfo.data fie= ld. Since we can't encode unicode / binary data, this breaks the JSON endpo= int and the webui. > = > This fixes the break, as well as allows browsing binary files in the webu= i (however, encoded as ASCII). > = > = > This addresses bug MESOS-274. > https://issues.apache.org/jira/browse/MESOS-274 > = > = > Diffs > ----- > = > src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666 = > third_party/libprocess/include/process/http.hpp ced8c1ab69952c4297d92b4= 72f8d3edb5954105c = > third_party/libprocess/include/stout/json.hpp 1c66dfd324619222f4ed168b7= cf18e8f5e558b23 = > third_party/libprocess/src/tests.cpp 131154abc920fa3904b7fa79faedb63f8d= 593793 = > = > Diff: https://reviews.apache.org/r/8056/diff/ > = > = > Testing > ------- > = > make check + added json test > = > = > Thanks, > = > Ben Mahler > = > --===============8805112068019145857==--