Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B11D7D948 for ; Wed, 12 Dec 2012 08:51:54 +0000 (UTC) Received: (qmail 83680 invoked by uid 500); 12 Dec 2012 08:51:54 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 83558 invoked by uid 500); 12 Dec 2012 08:51:54 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 83540 invoked by uid 99); 12 Dec 2012 08:51:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2012 08:51:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 483131C4406; Wed, 12 Dec 2012 08:51:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6463623479654736279==" MIME-Version: 1.0 Subject: Re: Review Request: Slave Restart (Part Tres): StatusUpdatesManager integration into the slave From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Wed, 12 Dec 2012 08:51:49 -0000 Message-ID: <20121212085149.7759.55801@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7655/ X-Sender: "Vinod Kone" References: <20121211000154.7759.81972@reviews.apache.org> In-Reply-To: <20121211000154.7759.81972@reviews.apache.org> Reply-To: "Vinod Kone" --===============6463623479654736279== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7655/ ----------------------------------------------------------- (Updated Dec. 12, 2012, 8:51 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- Moved 'checkpoint' from Task to Framework. In other words, the granularity= of checkpointing is at the framework level, instead of task level. This ma= kes thing simple. Doesn't address BenM's comments yet. P.S: Not sure why post-reviews thinks the test file is new!? Description ------- Integrated SUM into slave. Diffs (updated) ----- include/mesos/mesos.proto 38235157d45bdccb676e5c3241c21b585a6f8801 = src/Makefile.am b2d1edf140797c7150cb4644d323296965c4f000 = src/slave/gc.cpp 679504e51922c5ea54a476d061262e8e8f2aa4b6 = src/slave/paths.hpp 98e7fd402919c50a26f69a2f1a1904cb877c5f43 = src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba = src/slave/slave.cpp 28fd4c336d8ac658cf92811d20066a6cfdf5a95e = src/slave/status_update_manager.hpp PRE-CREATION = src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed = src/tests/status_update_manager_tests.cpp PRE-CREATION = Diff: https://reviews.apache.org/r/7655/diff/ Testing ------- make check Thanks, Vinod Kone --===============6463623479654736279==--