Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B86F99DAC for ; Tue, 11 Dec 2012 23:47:39 +0000 (UTC) Received: (qmail 76866 invoked by uid 500); 11 Dec 2012 23:47:39 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 76845 invoked by uid 500); 11 Dec 2012 23:47:39 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 76834 invoked by uid 99); 11 Dec 2012 23:47:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2012 23:47:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2E5681C555A; Tue, 11 Dec 2012 23:47:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4131605886784375354==" MIME-Version: 1.0 Subject: Re: Review Request: Added new test fixture to properly setup and teardown slave working directory From: "Benjamin Hindman" To: "Benjamin Hindman" , "Ben Mahler" Cc: "Vinod Kone" , "mesos" Date: Tue, 11 Dec 2012 23:47:35 -0000 Message-ID: <20121211234735.7729.38663@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8055/ X-Sender: "Benjamin Hindman" References: <20121115234219.10524.94032@reviews.apache.org> In-Reply-To: <20121115234219.10524.94032@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============4131605886784375354== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8055/#review14330 ----------------------------------------------------------- src/tests/utils.hpp s/MesosSetup/MesosTest/ src/tests/utils.hpp s/=3D d/=3D d/ - Benjamin Hindman On Nov. 15, 2012, 11:42 p.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8055/ > ----------------------------------------------------------- > = > (Updated Nov. 15, 2012, 11:42 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > I envisage this new test fixture to do a lot more than creating/deleting = working directories. But thats probably for another review. > = > = > Diffs > ----- > = > src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503 = > src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f6= 51f961392 = > src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534d= c5 = > src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1= a92df = > src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a= 34226 = > src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed = > src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456= 694c6 = > src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6 = > src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13 = > src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0 = > = > Diff: https://reviews.apache.org/r/8055/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============4131605886784375354==--