Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB6EEE238 for ; Fri, 7 Dec 2012 21:47:20 +0000 (UTC) Received: (qmail 33143 invoked by uid 500); 7 Dec 2012 21:47:20 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 33115 invoked by uid 500); 7 Dec 2012 21:47:20 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 33104 invoked by uid 99); 7 Dec 2012 21:47:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 21:47:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 76A791C53B1; Fri, 7 Dec 2012 21:47:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8538777034919190179==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for python bindings to allow null bytes in messages. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 07 Dec 2012 21:47:16 -0000 Message-ID: <20121207214716.19218.76175@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8362/ X-Sender: "Ben Mahler" References: <20121207203342.19201.99108@reviews.apache.org> In-Reply-To: <20121207203342.19201.99108@reviews.apache.org> Reply-To: "Ben Mahler" --===============8538777034919190179== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Dec. 7, 2012, 8:33 p.m., Vinod Kone wrote: > > src/examples/python/test_framework.py, line 112 > > > > > > s/only// > > = > > in this test, received cannot be less than sent can it? it was less with the null bug, but now it should match exactly > On Dec. 7, 2012, 8:33 p.m., Vinod Kone wrote: > > src/python/src/mesos.py, line 34 > > > > > > this doesn't match the signature in scheduler.hpp. wonder how it ev= er worked? Dynamic type system combined with inadequate test coverage ;) > On Dec. 7, 2012, 8:33 p.m., Vinod Kone wrote: > > src/python/src/mesos.py, line 68 > > > > > > this doesn't match the signature in executor.hpp? > > = > > did you mean to change the signature for scheduler instead of execu= tor? Yep, thanks for catching that! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8362/#review14180 ----------------------------------------------------------- On Dec. 7, 2012, 8:21 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8362/ > ----------------------------------------------------------- > = > (Updated Dec. 7, 2012, 8:21 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > See MESOS-317. > = > = > This addresses bug MESOS-317. > https://issues.apache.org/jira/browse/MESOS-317 > = > = > Diffs > ----- > = > src/examples/python/test_executor.py 0e38b1221dd7edc80b9e847663d6add6ac= c5a3f7 = > src/examples/python/test_framework.py f436865b32c555a593e7cbb2c35b8cdae= 439932a = > src/python/native/mesos_executor_driver_impl.cpp cd4494cbdce9dd23101f15= f6c5630404b4310f3e = > src/python/native/mesos_scheduler_driver_impl.cpp 0fcbafa38650d80f2822e= 55983cd10550b1be2df = > src/python/native/proxy_executor.cpp 343d42831046ac28bb1503d480b8679f5b= c72b97 = > src/python/native/proxy_scheduler.cpp 53a8d57f288620acb21c82a982e8a87f5= 120af57 = > src/python/src/mesos.py 39d37b8d6e9b41bc736df41a000a6347d4b189ef = > = > Diff: https://reviews.apache.org/r/8362/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Ben Mahler > = > --===============8538777034919190179==--