Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D40ADDF9C for ; Fri, 7 Dec 2012 18:06:34 +0000 (UTC) Received: (qmail 37826 invoked by uid 500); 7 Dec 2012 18:06:34 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 37769 invoked by uid 500); 7 Dec 2012 18:06:34 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 37740 invoked by uid 99); 7 Dec 2012 18:06:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 18:06:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D57F31C5365; Fri, 7 Dec 2012 18:06:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0380229409787225119==" MIME-Version: 1.0 Subject: Review Request: Fixed compilation issues on Ubuntu 10.04. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 07 Dec 2012 18:06:28 -0000 Message-ID: <20121207180628.19200.23271@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8415/ X-Sender: "Ben Mahler" Reply-To: "Ben Mahler" --===============0380229409787225119== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8415/ ----------------------------------------------------------- Review request for mesos, Benjamin Hindman and Vinod Kone. Description ------- The new proc code has issues compiling on Ubuntu 10.04 with gcc 4.4.3. There is a known issue in this gcc version with false warnings of this type: ../../src/linux/proc.hpp: In member function =E2=80=98virtual void CgroupsC= pusetTest_ManyCPUManyCpusets_Test::TestBody()=E2=80=99: ../../src/linux/proc.hpp:81: error: dereferencing pointer =E2=80=98=E2=80=99 does break strict-aliasing rules ../../src/linux/proc.hpp:86: error: dereferencing pointer =E2=80=98=E2=80=99 does break strict-aliasing rules ../../src/linux/proc.hpp:76: error: dereferencing pointer =E2=80=98=E2=80=99 does break strict-aliasing rules /usr/include/c++/4.4/bits/stl_tree.h:175: note: initialized from here Diffs ----- src/linux/proc.hpp 6c84a73ab1c4d6893390f96eae15422c21001328 = src/tests/cgroups_isolation_tests.cpp 41d6ac9d6331bcfd1e57d403e13a1d27cd5= d14bc = Diff: https://reviews.apache.org/r/8415/diff/ Testing ------- make check on Ubuntu 10.04 Thanks, Ben Mahler --===============0380229409787225119==--