Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3070040493266257189=="
MIME-Version: 1.0
Subject: Re: Review Request: Properly deallocates exited executor's resources"
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "mesos" <mesos-dev@incubator.apache.org>,
 "Vinod Kone" <vinodkone@gmail.com>
Date: Thu, 29 Nov 2012 09:37:30 -0000
Message-ID: <20121129093730.21810.25273@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vinod Kone" <noreply@reviews.apache.org>
References: <20121129030756.21810.71904@reviews.apache.org>
In-Reply-To: <20121129030756.21810.71904@reviews.apache.org>
Reply-To: "Vinod Kone" <vinodkone@gmail.com>

--===============3070040493266257189==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On Nov. 29, 2012, 3:07 a.m., Ben Mahler wrote:
> > src/slave/cgroups_isolation_module.cpp, line 940
> > <https://reviews.apache.org/r/8255/diff/1/?file=3D231391#file231391line=
940>
> >
> >     You need to store the result of the shrink and apply it to the cpus=
 (similarly to how cpusetChanged() works).

done


> On Nov. 29, 2012, 3:07 a.m., Ben Mahler wrote:
> > src/slave/cgroups_isolation_module.cpp, line 707
> > <https://reviews.apache.org/r/8255/diff/1/?file=3D231391#file231391line=
707>
> >
> >     Can you get this all in one log line? Meaning, build up a string an=
d do one LOG call?
> >     =

> >     Otherwise it will be a little tricky to read interspersed with othe=
r logging.

done


> On Nov. 29, 2012, 3:07 a.m., Ben Mahler wrote:
> > src/slave/cgroups_isolation_module.cpp, line 695
> > <https://reviews.apache.org/r/8255/diff/1/?file=3D231391#file231391line=
695>
> >
> >     Instead of printCpusets(): logCpusets()?
> >     =

> >     But even better:
> >     LOG(INFO) << cpusetsState(); // where cpusetsState() returns the st=
ring.
> >     =

> >     I'm seeing now that if we had Cpuset as a tree, this stuff could be=
 a bit cleaner, but that's a bigger change so let's forget it for now.

sure.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8255/#review13837
-----------------------------------------------------------


On Nov. 29, 2012, 12:02 a.m., Vinod Kone wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8255/
> -----------------------------------------------------------
> =

> (Updated Nov. 29, 2012, 12:02 a.m.)
> =

> =

> Review request for mesos, Benjamin Hindman and Ben Mahler.
> =

> =

> Description
> -------
> =

> Tested by modifying balloon framework test to start the slave cpusets ena=
bled.
> =

> Will be writing more tests soon.
> =

> =

> Diffs
> -----
> =

>   src/slave/cgroups_isolation_module.hpp 9f80fc5a969b959b34eaea4cac407006=
62d7f8b2 =

>   src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912=
ed9dda6a =

>   src/tests/balloon_framework_test.sh 93a733f64cfde08349b7781eb3d5e13594c=
74498 =

> =

> Diff: https://reviews.apache.org/r/8255/diff/
> =

> =

> Testing
> -------
> =

> udo GLOG_v=3D1 ./bin/mesos-tests.sh --verbose --gtest_filter=3D*Cgroup*
> =

> =

> Thanks,
> =

> Vinod Kone
> =

>


--===============3070040493266257189==--