Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21EBFDFB3 for ; Mon, 19 Nov 2012 15:48:39 +0000 (UTC) Received: (qmail 79406 invoked by uid 500); 19 Nov 2012 15:48:39 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 79271 invoked by uid 500); 19 Nov 2012 15:48:37 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 79244 invoked by uid 99); 19 Nov 2012 15:48:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2012 15:48:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A82161C4B1F; Mon, 19 Nov 2012 15:48:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6934595229839819944==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for doing executor setup inside the forked process in cgroups isolation module From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Mon, 19 Nov 2012 15:48:33 -0000 Message-ID: <20121119154833.3328.57356@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8096/ X-Sender: "Vinod Kone" References: <20121118003338.13674.45471@reviews.apache.org> In-Reply-To: <20121118003338.13674.45471@reviews.apache.org> Reply-To: "Vinod Kone" --===============6934595229839819944== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 18, 2012, 12:33 a.m., Ben Mahler wrote: > > Great, this is all that's needed to fix MESOS-310 right? > > = > > Also, I recall some discussion about this bit of code already, in terms= of where to place it, do you remember what the context was? We wanted to split the launcher because it was being called both from the s= lave process and its forked process. I think we are fine now because all of= the launcher code is being called inside the forked process. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8096/#review13541 ----------------------------------------------------------- On Nov. 16, 2012, 11:24 p.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8096/ > ----------------------------------------------------------- > = > (Updated Nov. 16, 2012, 11:24 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > Now, we do the executor setup (fetching etc) inside the forked process bu= t before assigning the process to its own cgroup. > = > This accomplishes two things: > --> unblocks the cgroups isolation module from any potential hangs during= executor setup > --> does not charge (for memory) the executor for the setup > = > = > This addresses bug MESOS-310. > https://issues.apache.org/jira/browse/MESOS-310 > = > = > Diffs > ----- > = > src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912= ed9dda6a = > src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576= ab8a38c5ce57ad = > = > Diff: https://reviews.apache.org/r/8096/diff/ > = > = > Testing > ------- > = > sudo make check > = > = > Thanks, > = > Vinod Kone > = > --===============6934595229839819944==--