Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E560DD6F1 for ; Thu, 15 Nov 2012 23:54:44 +0000 (UTC) Received: (qmail 77506 invoked by uid 500); 15 Nov 2012 23:54:44 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 77456 invoked by uid 500); 15 Nov 2012 23:54:44 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 77445 invoked by uid 99); 15 Nov 2012 23:54:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2012 23:54:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A114B1C4AC9; Thu, 15 Nov 2012 23:54:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1206719009334573750==" MIME-Version: 1.0 Subject: Re: Review Request: Added registration timeout for executors From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Thu, 15 Nov 2012 23:54:41 -0000 Message-ID: <20121115235441.10558.58342@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/8077/ X-Sender: "Vinod Kone" References: <20121115235346.10524.48484@reviews.apache.org> In-Reply-To: <20121115235346.10524.48484@reviews.apache.org> Reply-To: "Vinod Kone" --===============1206719009334573750== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8077/ ----------------------------------------------------------- (Updated Nov. 15, 2012, 11:54 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- BenM's comments Description ------- This paves the way for a slave to shutdown executors that are not responsiv= e during launch (e.g. HDFS hang during fetching executor). This fix is not enough for cgroups isolation module (enough for the process= based isolation module) because it currently blocks while launching an exe= cutor. This addresses bug MESOS-310. https://issues.apache.org/jira/browse/MESOS-310 Diffs (updated) ----- src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e1947= 3b943c7469dab = src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 = src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c = src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 = src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa= 2f0b25830faf = src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab= 8a38c5ce57ad = src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 = src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba = src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f = src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed = Diff: https://reviews.apache.org/r/8077/diff/ Testing ------- make check Thanks, Vinod Kone --===============1206719009334573750==--