incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <>
Subject Re: Review Request: Adding cpuset isolation to cgroups.
Date Thu, 22 Nov 2012 04:27:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 22, 2012, 4:27 a.m.)

Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.


My review posting tool keeps omitting jie, sorry about that!


This is the first pass at adding cpuset isolation for pinning cgroups to cpus.

We decided to start with a simplistic grow/shrink allocation technique, as such this initial
  -Does not take cache locality into account.
  -Does not actively fight fragmentation*, but does a good job at preventing it in many cases,
given it's simplicity.
  -Note that when cpus resource requests are integral (non-fractional), then fragmentation
does not occur.

*By fragmentation, I'm referring to the case where we've spread a cgroup over more cpus than
necessary, due to other cgroups sharing the same cpus.
High fragmentation would mean a lot of shared cpus across cgroups.
No fragmentation would mean each cgroup has a unique set of cpus.

I've punted on documenting the pitfalls of this technique, wiring up the handler, and adding
tests for now.

Note that this is diffed off of benh's changes:


  src/linux/proc.hpp 27e15bf8695aa694b0d5bdb6881b9fa55a447528 
  src/slave/cgroups_isolation_module.hpp 9f80fc5a969b959b34eaea4cac40700662d7f8b2 
  src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a 
  src/slave/isolation_module.hpp 4e7bfee4205b2a9953c06c7cc7128c9400ff79f4 
  src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893 
  src/slave/lxc_isolation_module.cpp 1d0a4c47386eedf610b10d40ad5300ff808cc1fd 
  src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
  src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
  src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6 
  third_party/libprocess/include/stout/stringify.hpp dcc5b95a54e6f34f93867e015d8c855fd7d6f950

  third_party/libprocess/include/stout/strings.hpp 914c280a994733764957d19f37b48d151bb93778



None as of yet.


Ben Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message