Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02187DFB0 for ; Thu, 25 Oct 2012 00:25:00 +0000 (UTC) Received: (qmail 34859 invoked by uid 500); 25 Oct 2012 00:24:59 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 34830 invoked by uid 500); 25 Oct 2012 00:24:59 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 34817 invoked by uid 99); 25 Oct 2012 00:24:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Oct 2012 00:24:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5E1B21C019F; Thu, 25 Oct 2012 00:24:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6748219248687974619==" MIME-Version: 1.0 Subject: Re: Review Request: Replacing executor run directory numbers with uuids. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Thu, 25 Oct 2012 00:24:57 -0000 Message-ID: <20121025002457.27001.37321@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7658/ X-Sender: "Ben Mahler" References: <20121022191636.28461.32279@reviews.apache.org> In-Reply-To: <20121022191636.28461.32279@reviews.apache.org> Reply-To: "Ben Mahler" --===============6748219248687974619== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7658/ ----------------------------------------------------------- (Updated Oct. 25, 2012, 12:24 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes ------- Also tried to make sure we don't refer to 'uuid's as 'run's. Description ------- This replaces our run directory numbers with the executor uuids. Ex: .../executorFoo/runs/0 .../executorFoo/runs/1111-1111-1111-1111 This ensures we don't ever write to an old directory that was gc'ed. Diffs (updated) ----- src/slave/paths.hpp 48a7be0ae33785206ebb1985647178224d6bcfb8 = src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 = src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c = src/slave/state.hpp dcadd511063584cde51f533e2120f4eab5145fd2 = src/slave/state.cpp c8406fbb5586bca5b7f169a2ef937c958626dee1 = src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f = third_party/libprocess/include/stout/fs.hpp 1516d0b6fa6e0ced26bb08ab6a4fa= df28232124f = Diff: https://reviews.apache.org/r/7658/diff/ Testing ------- Updated tests + make check. Thanks, Ben Mahler --===============6748219248687974619==--