Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B80F5D07F for ; Mon, 15 Oct 2012 16:58:28 +0000 (UTC) Received: (qmail 5025 invoked by uid 500); 15 Oct 2012 16:58:28 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 4959 invoked by uid 500); 15 Oct 2012 16:58:28 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 4864 invoked by uid 99); 15 Oct 2012 16:58:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Oct 2012 16:58:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B2F2C1C44DF; Mon, 15 Oct 2012 16:58:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3749491823466646219==" MIME-Version: 1.0 Subject: Re: Review Request: Changing FilesProcess to use async io::read, updated pailer to not use redundant 'length' field of response. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Mon, 15 Oct 2012 16:58:25 -0000 Message-ID: <20121015165825.16968.38333@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7048/ X-Sender: "Benjamin Hindman" References: <20121012215627.19252.59462@reviews.apache.org> In-Reply-To: <20121012215627.19252.59462@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============3749491823466646219== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review12431 ----------------------------------------------------------- Ship it! Also, if you can rebase this that would be amazing! third_party/libprocess/src/process.cpp If you want the test below to always be testing what you expect, then I= 'd suggest factoring out this value into io.hpp as READ_SIZE or something s= imilar and using that in the test. - Benjamin Hindman On Oct. 12, 2012, 9:56 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > = > (Updated Oct. 12, 2012, 9:56 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > see above > = > also: > -removed redundant length field from json > -added missing test for buffered io::read > = > = > Diffs > ----- > = > src/files/files.cpp 6d41bf6649479f83b1f5f56665b555c0c553e713 = > src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d = > src/webui/master/static/jquery.pailer.js edd23d9efa03086679af67a8bd13a2= 73d409798b = > third_party/libprocess/include/process/io.hpp 722b15f11db4d3b6c941c8b4a= 6c5d395b11b035f = > third_party/libprocess/src/process.cpp e887feb1070cdd03a6d81b8f798145ed= 8bda7b5c = > third_party/libprocess/src/tests.cpp 9cae36aede41bc1e6bb966122c581cff97= 483717 = > = > Diff: https://reviews.apache.org/r/7048/diff/ > = > = > Testing > ------- > = > make check on osx, and redhat > = > mesos-local.sh to verify pailer > = > = > Thanks, > = > Ben Mahler > = > --===============3749491823466646219==--