Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4032B9538 for ; Fri, 12 Oct 2012 20:57:10 +0000 (UTC) Received: (qmail 63394 invoked by uid 500); 12 Oct 2012 20:57:10 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 63369 invoked by uid 500); 12 Oct 2012 20:57:10 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 63352 invoked by uid 99); 12 Oct 2012 20:57:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2012 20:57:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 18B651C015C; Fri, 12 Oct 2012 20:57:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5969451116100311346==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for log viewing with mesos-local.sh runs. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 12 Oct 2012 20:57:08 -0000 Message-ID: <20121012205708.19252.79443@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7061/ X-Sender: "Ben Mahler" References: <20121012202312.19252.65647@reviews.apache.org> In-Reply-To: <20121012202312.19252.65647@reviews.apache.org> Reply-To: "Ben Mahler" --===============5969451116100311346== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7061/ ----------------------------------------------------------- (Updated Oct. 12, 2012, 8:57 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes ------- Removed the stray diffs. Description ------- This eliminates the hard-coding of the log filenames: mesos-master.INFO and= mesos-slave.INFO. Diffs (updated) ----- src/logging/logging.hpp 9dcc7c1832d16aefbb14d77166641819b7a4bf56 = src/logging/logging.cpp fce61eb9fec3ba368d6e2fe34d03a94940e85710 = src/master/master.cpp e6c9ede0bcb3a8b1327d80e8ef752a080a8ece65 = src/slave/slave.cpp a03042754b2101ee4be763b8cc7eb85fecfab36b = src/webui/master/static/controllers.js 81cd1a861dcf86fb8852999a017595824d= ffb3f0 = Diff: https://reviews.apache.org/r/7061/diff/ Testing ------- make check mesos-local.sh runs Thanks, Ben Mahler --===============5969451116100311346==--