Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A8C01D3D5 for ; Thu, 11 Oct 2012 00:46:08 +0000 (UTC) Received: (qmail 7181 invoked by uid 500); 11 Oct 2012 00:46:08 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 7138 invoked by uid 500); 11 Oct 2012 00:46:08 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 7126 invoked by uid 99); 11 Oct 2012 00:46:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Oct 2012 00:46:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B6A91C4297; Thu, 11 Oct 2012 00:46:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1755976527569964368==" MIME-Version: 1.0 Subject: Re: Review Request: Changing FilesProcess to use async io::read, updated pailer to not use redundant 'length' field of response. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Thu, 11 Oct 2012 00:46:06 -0000 Message-ID: <20121011004606.19280.31232@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7048/ X-Sender: "Ben Mahler" References: <20121010214619.19280.28874@reviews.apache.org> In-Reply-To: <20121010214619.19280.28874@reviews.apache.org> Reply-To: "Ben Mahler" --===============1755976527569964368== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/ ----------------------------------------------------------- (Updated Oct. 11, 2012, 12:46 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes ------- Fixed whitespace alignment. Description ------- see above also: -removed redundant length field from json -added missing test for buffered io::read Diffs (updated) ----- src/files/files.cpp 6d41bf6649479f83b1f5f56665b555c0c553e713 = src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d = src/webui/master/static/jquery.pailer.js edd23d9efa03086679af67a8bd13a273= d409798b = third_party/libprocess/include/process/io.hpp 722b15f11db4d3b6c941c8b4a6c= 5d395b11b035f = third_party/libprocess/src/process.cpp fde7154f9a4432acaff09849c0fa69c069= 4c9834 = third_party/libprocess/src/tests.cpp 1cb26cd1729ce1cf0ed9573d3eb40690705d= 4b4e = Diff: https://reviews.apache.org/r/7048/diff/ Testing ------- make check on osx, and redhat mesos-local.sh to verify pailer Thanks, Ben Mahler --===============1755976527569964368==--