Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2DDF4D0FA for ; Wed, 10 Oct 2012 21:46:28 +0000 (UTC) Received: (qmail 67101 invoked by uid 500); 10 Oct 2012 21:46:28 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 67020 invoked by uid 500); 10 Oct 2012 21:46:27 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 67008 invoked by uid 99); 10 Oct 2012 21:46:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Oct 2012 21:46:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E3D5F1C4286; Wed, 10 Oct 2012 21:46:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1068619253399041320==" MIME-Version: 1.0 Subject: Re: Review Request: Changing FilesProcess to use async io::read, updated pailer to not use redundant 'length' field of response. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Wed, 10 Oct 2012 21:46:25 -0000 Message-ID: <20121010214625.19280.56317@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7048/ X-Sender: "Ben Mahler" References: <20121010191756.19252.73889@reviews.apache.org> In-Reply-To: <20121010191756.19252.73889@reviews.apache.org> Reply-To: "Ben Mahler" --===============1068619253399041320== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Oct. 10, 2012, 7:17 p.m., Vinod Kone wrote: > > src/tests/files_tests.cpp, line 105 > > > > > > checking on the body is nice but i suspect this is too brittle, whe= n someone changes the response string. This is borrowed from benh's tests (logging_tests.cpp). I think I also like checking the string because it ensures: 1. The request fails _for the correct reason_. 2. We're providing good diagnostic output to the end user. If someone changes the response string the test will fail, and they'll upda= te it. :) > On Oct. 10, 2012, 7:17 p.m., Vinod Kone wrote: > > src/files/files.cpp, line 260 > > > > > > Is this cap documented somewhere for the users of read()? Maybe a w= arning is in order? This is documented in the pailer, in terms of what it expects of the read f= unction provided to it. However, the documentation is lacking here, so I've updated each HTTP endpo= int function documentation. Please read through the documentation I've adde= d to the function signatures. Things are ok when this cap occurs, it's merely mimics how the read syscall= behaves. Let me know what you think! > On Oct. 10, 2012, 7:17 p.m., Vinod Kone wrote: > > third_party/libprocess/src/tests.cpp, line 1233 > > > > > > bad diff? hm.. looks like it! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review12316 ----------------------------------------------------------- On Oct. 10, 2012, 9:46 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > = > (Updated Oct. 10, 2012, 9:46 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > see above > = > also: > -removed redundant length field from json > -added missing test for buffered io::read > = > = > Diffs > ----- > = > src/files/files.cpp 6d41bf6649479f83b1f5f56665b555c0c553e713 = > src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d = > src/webui/master/static/jquery.pailer.js edd23d9efa03086679af67a8bd13a2= 73d409798b = > third_party/libprocess/include/process/io.hpp 722b15f11db4d3b6c941c8b4a= 6c5d395b11b035f = > third_party/libprocess/src/process.cpp fde7154f9a4432acaff09849c0fa69c0= 694c9834 = > third_party/libprocess/src/tests.cpp 1cb26cd1729ce1cf0ed9573d3eb4069070= 5d4b4e = > = > Diff: https://reviews.apache.org/r/7048/diff/ > = > = > Testing > ------- > = > make check on osx, and redhat > = > mesos-local.sh to verify pailer > = > = > Thanks, > = > Ben Mahler > = > --===============1068619253399041320==--