Return-Path: 
 <mesos-dev-return-4001-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 004C2D157
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Mon,  8 Oct 2012 19:39:07 +0000 (UTC)
Received: (qmail 63004 invoked by uid 500); 8 Oct 2012 19:39:06 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 62978 invoked by uid 500); 8 Oct 2012 19:39:06 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 62965 invoked by uid 99); 8 Oct 2012 19:39:06 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2012 19:39:06 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id DE45C1C0022;
	Mon,  8 Oct 2012 19:39:04 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4160371631433670314=="
MIME-Version: 1.0
Subject: Re: Review Request: Better error messages
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "mesos" <mesos-dev@incubator.apache.org>,
 "Vinod Kone" <vinodkone@gmail.com>
Date: Mon, 08 Oct 2012 19:39:04 -0000
Message-ID: <20121008193904.20408.13555@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/7454/
X-Sender: "Ben Mahler" <noreply@reviews.apache.org>
References: <20121008192707.20408.26150@reviews.apache.org>
In-Reply-To: <20121008192707.20408.26150@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>

--===============4160371631433670314==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7454/#review12238
-----------------------------------------------------------



third_party/libprocess/include/stout/net.hpp
<https://reviews.apache.org/r/7454/#comment25974>

    I guess I should have been more clear:
    =

    s/return code/HTTP Response Code



third_party/libprocess/include/stout/net.hpp
<https://reviews.apache.org/r/7454/#comment25972>

    Ok now we can just return fd directly since it's a Try<int> with the ap=
propriate error, right?
    =

    This convention works if we've augmented all of our os Try::error strin=
gs in os, but I could be convinced otherwise :)



third_party/libprocess/include/stout/net.hpp
<https://reviews.apache.org/r/7454/#comment25973>

    Feel free to punt, but eventually we'd likely want fdopen, fclose wrapp=
ers in stout/fs.hpp.


- Ben Mahler


On Oct. 8, 2012, 7:27 p.m., Vinod Kone wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7454/
> -----------------------------------------------------------
> =

> (Updated Oct. 8, 2012, 7:27 p.m.)
> =

> =

> Review request for mesos, Benjamin Hindman and Ben Mahler.
> =

> =

> Description
> -------
> =

> Better error messages
> =

> =

> Fix for curl download
> =

> =

> Diffs
> -----
> =

>   src/launcher/launcher.cpp 5de1f479cf03182a1c12bdd951b5bd57c00ee2ee =

>   third_party/libprocess/include/stout/net.hpp f6b770c8ca7d21e0aca0f61416=
8a0985c77046b0 =

>   third_party/libprocess/include/stout/os.hpp 13dbc715ed08cfe6b24ee20744d=
427dac1104694 =

> =

> Diff: https://reviews.apache.org/r/7454/diff/
> =

> =

> Testing
> -------
> =

> Tested locally
> =

> =

> Thanks,
> =

> Vinod Kone
> =

>


--===============4160371631433670314==--