incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <>
Subject Re: Review Request: Refactored and simplified the ZooKeeper test fixture(s) and tests. In particular:
Date Fri, 26 Oct 2012 18:11:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 26, 2012, 6:11 p.m.)

Review request for mesos, Vinod Kone and Ben Mahler.


Updates from review comments.

Summary (updated)

Refactored and simplified the ZooKeeper test fixture(s) and tests. In particular:


In particular:
    (a) Eliminated the verbose logging coming from the
        AllocatorZooKeeperTest tests that was causing a lot of output when
        the tests ran.
    (b) Made sure all the ZooKeeper clients are properly shutdown in the
        AllocatorZooKeeperTest tests (this was mainly just invoking
        MasterDetector::destroy on all created detectors).
    (c) Renamed ZooKeeperServer to ZooKeeperServerTest so as not to
        conflate it with the Java class
    (d) Added an AssertZKGet helper to get better error messages.
    Updated BaseZooKeeperTest fixture to shutdown embedeed JVM after the
    tests have completed.

Diffs (updated)

  src/ cf9364ea0418ec30a75b1774f32bda8de6e031ac 
  src/jvm/jvm.hpp c3ec99248ccb66c1803da2c102ff9be0fb8ddd17 
  src/sched/sched.cpp 5a4e594a3a8a2089cf74e7e418f2e7bde4c03e9d 
  src/tests/allocator_zookeeper_tests.cpp bd408c22df5edc3684791e509ce1a4c210553922 
  src/tests/base_zookeeper_test.hpp 06da416d79beb8cd5cf3fa8d102be973b8feb4b6 
  src/tests/base_zookeeper_test.cpp a188332dd9703ffadbfb2844a9d10363675203a9 
  src/tests/state_tests.cpp 0b4aac28f087ad4032fb37f536fb90cd0649e500 
  src/tests/zookeeper_server.hpp 6355e8479a636c889945eead12d863b827d78929 
  src/tests/zookeeper_server.cpp 817665c14c656b5cdcf930652aab46128839eaf2 
  src/tests/zookeeper_server_tests.cpp 7585fa6b837aab60aed0367bdd7582248bfb5a21 
  src/tests/zookeeper_test.hpp PRE-CREATION 
  src/tests/zookeeper_test.cpp PRE-CREATION 
  src/tests/zookeeper_test_server.hpp PRE-CREATION 
  src/tests/zookeeper_test_server.cpp PRE-CREATION 
  src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8 



make check


Benjamin Hindman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message