Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0FAC7D817 for ; Tue, 11 Sep 2012 17:32:07 +0000 (UTC) Received: (qmail 55658 invoked by uid 500); 11 Sep 2012 17:32:06 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 55624 invoked by uid 500); 11 Sep 2012 17:32:06 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 55613 invoked by uid 99); 11 Sep 2012 17:32:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 17:32:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE3B31C1F60; Tue, 11 Sep 2012 17:32:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7837931153173315357==" MIME-Version: 1.0 Subject: Re: Review Request: Testing updates (see description). From: "Ben Mahler" To: "Ben Mahler" Cc: "Benjamin Hindman" , "mesos" Date: Tue, 11 Sep 2012 17:32:05 -0000 Message-ID: <20120911173205.1602.1621@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7008/ X-Sender: "Ben Mahler" References: <20120911054452.1602.42848@reviews.apache.org> In-Reply-To: <20120911054452.1602.42848@reviews.apache.org> Reply-To: "Ben Mahler" --===============7837931153173315357== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7008/#review11334 ----------------------------------------------------------- src/tests/logging_tests.cpp hm.. I see why you did this, no simple/clean way to not hardcode this src/tests/logging_tests.cpp I missed some BadRequest tests in files do you mind adding some tests i= n files? = read.json without 'path=3D...' read.json with un-parseable 'length=3D...' read.json with un-parseable 'offset=3D...' = browse.json without 'path=3D...' = if you don't want to bundle that in this CL, let me know and I'll follo= w up on this one src/tests/utils.hpp nice catch src/tests/zookeeper_tests.cpp this is great cleanup! third_party/libprocess/include/process/process.hpp one line? = P.S. I haven't noticed these javadoc style comments: /** * @param foo ... */ = Do you still encourage commenting in this manner? - Ben Mahler On Sept. 11, 2012, 5:44 a.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7008/ > ----------------------------------------------------------- > = > (Updated Sept. 11, 2012, 5:44 a.m.) > = > = > Review request for mesos and Ben Mahler. > = > = > Description > ------- > = > Used new ASSERT/EXPECT_FUTURE_* within some existing tests as well as add= ed ASSERT/EXPECT_FUTURE_WILL_EQ and EXPECT_RESPONSE_BODY_WILL_EQ. Also adde= d new tests for logging HTTP interface thanks to process::http::get. > = > = > Diffs > ----- > = > src/Makefile.am b73a024 = > src/tests/files_tests.cpp 6ef2004 = > src/tests/logging_tests.cpp PRE-CREATION = > src/tests/utils.hpp 79999b5 = > src/tests/zookeeper_tests.cpp 19c2dfa = > third_party/libprocess/include/process/process.hpp 76da79b = > third_party/libprocess/src/process.cpp 2d2b56c = > = > Diff: https://reviews.apache.org/r/7008/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Benjamin Hindman > = > --===============7837931153173315357==--