Return-Path: 
 <mesos-dev-return-3652-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 01E34D8D3
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Tue, 11 Sep 2012 17:05:11 +0000 (UTC)
Received: (qmail 71936 invoked by uid 500); 11 Sep 2012 17:05:10 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 71906 invoked by uid 500); 11 Sep 2012 17:05:10 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 71874 invoked by uid 99); 11 Sep 2012 17:05:09 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 17:05:09 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 94B611C1F60;
	Tue, 11 Sep 2012 17:05:08 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8367334850288783559=="
MIME-Version: 1.0
Subject: Review Request: Refactoring unnecessary 'Try<bool>' into 'Try<void>'
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>, "Jie Yu" <yujie.jay@gmail.com>,
 "Vinod Kone" <vinodkone@gmail.com>
Cc: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Tue, 11 Sep 2012 17:05:08 -0000
Message-ID: <20120911170508.1611.95667@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/7001/
X-Sender: "Ben Mahler" <noreply@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>

--===============8367334850288783559==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7001/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.


Description
-------

We unnecessarily have Try<bool>s all over the place, these are tri-state: {=
error, some:true, some:false}. It seems most cases, we never use {some:fals=
e} in the function or the caller.

So, this restores some sanity to use two-state Try<void>s: {error, some}


Diffs
-----

  src/linux/cgroups.hpp 1a3cdc2 =

  src/linux/cgroups.cpp 53d611f =

  src/linux/fs.hpp 31a6100 =

  src/linux/fs.cpp 744aea6 =

  src/logging/logging.cpp d6d31ec =

  src/slave/cgroups_isolation_module.hpp 00255b5 =

  src/slave/cgroups_isolation_module.cpp 8a121e0 =

  src/slave/gc.hpp 3760d09 =

  src/slave/gc.cpp 5212a41 =

  src/slave/process_based_isolation_module.cpp c0576bd =

  src/slave/slave.cpp 4ea1db1 =

  src/tests/cgroups_tests.cpp fbaa046 =

  src/tests/configurator_tests.cpp 8baed76 =

  src/tests/files_tests.cpp 6ef2004 =

  src/tests/stout_tests.cpp f690fac =

  src/tests/zookeeper_server.hpp 4f34910 =

  src/webui/webui.cpp d4f2ab9 =

  third_party/libprocess/include/stout/os.hpp 602db1f =

  third_party/libprocess/src/process.cpp 2d2b56c =


Diff: https://reviews.apache.org/r/7001/diff/


Testing
-------

osx 10.7 gcc 4.2.1
redhat Red Hat 4.1.2-48 gcc 4.1.2

make
make check

note that SampleFrameworks.PythonFramework is consistently failing on red h=
at, unrelated to this change


Thanks,

Ben Mahler


--===============8367334850288783559==--