Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B953ADF4F for ; Thu, 23 Aug 2012 02:28:07 +0000 (UTC) Received: (qmail 81623 invoked by uid 500); 23 Aug 2012 02:28:07 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 81597 invoked by uid 500); 23 Aug 2012 02:28:07 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 81580 invoked by uid 99); 23 Aug 2012 02:28:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2012 02:28:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 42CAC1C1CAB; Thu, 23 Aug 2012 02:28:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1596074727471862274==" MIME-Version: 1.0 Subject: Re: Review Request: Slave GC based on disk usage From: "Ben Mahler" To: "Benjamin Hindman" , "Ben Mahler" , "John Sirois" Cc: "mesos" , "Vinod Kone" Date: Thu, 23 Aug 2012 02:28:07 -0000 Message-ID: <20120823022807.1112.37896@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/6704/ X-Sender: "Ben Mahler" References: <20120821232019.15255.14001@reviews.apache.org> In-Reply-To: <20120821232019.15255.14001@reviews.apache.org> Reply-To: "Ben Mahler" --===============1596074727471862274== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6704/#review10603 ----------------------------------------------------------- src/slave/constants.hpp so does 1 week seem correct? = using the math you have below: disk 50% = max_age 3.5 days = disk 75% max_age 1.75 days = do we actually see the disks fill up this rapidly? perhaps initially we= should be less agressive on this age, like set 2x or 3x on the current gc_= timeout_hours = of course, ben and you know much more about the typical disk usage patt= erns than I do, so let me know your opinion please :) src/slave/constants.hpp seems a bit frequent no? what does statvfs do under the hood? src/slave/gc.hpp kill these new imports, and put them in the cpp file instead? src/slave/gc.cpp this will just print true or false, would be nice to have the actual er= ror here, so how about we LOG in os::rmdir() when anything goes wrong? = = src/slave/gc.cpp move the log line within the if? looks really noisy src/slave/slave.cpp can you nicely format this number, like %.2f src/slave/slave.cpp I'm not getting the math here: = current gc timeout hours: 1 week suppose max age: 1 day = then = 1 week - 1 day =3D 6 days = so we would prune everything scheduled for deletion within the next 6 d= ays...? = - Ben Mahler On Aug. 21, 2012, 11:20 p.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6704/ > ----------------------------------------------------------- > = > (Updated Aug. 21, 2012, 11:20 p.m.) > = > = > Review request for mesos, Benjamin Hindman, John Sirois, and Ben Mahler. > = > = > Description > ------- > = > Added the ability in the slave to GC executor directories based on the cu= rrent disk usage. > = > Currently, it uses a very simple algorithm to decide which directories to= delete. > = > = > This addresses bug MESOS-254. > https://issues.apache.org/jira/browse/MESOS-254 > = > = > Diffs > ----- > = > src/slave/constants.hpp ab83972 = > src/slave/flags.hpp 0c7917f = > src/slave/gc.hpp 6704742 = > src/slave/gc.cpp 9c01024 = > src/slave/slave.hpp 10c537b = > src/slave/slave.cpp 4efd41e = > src/tests/gc_tests.cpp 2f0bdde = > third_party/libprocess/include/stout/os.hpp b1eceb3 = > = > Diff: https://reviews.apache.org/r/6704/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============1596074727471862274==--