Return-Path: 
 <mesos-dev-return-3147-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AB01FD8DC
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Fri,  3 Aug 2012 19:20:15 +0000 (UTC)
Received: (qmail 67022 invoked by uid 500); 3 Aug 2012 19:20:15 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 66952 invoked by uid 500); 3 Aug 2012 19:20:15 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 66942 invoked by uid 99); 3 Aug 2012 19:20:15 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2012 19:20:15 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id EC4461C04AA;
	Fri,  3 Aug 2012 19:20:13 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============9047625559266305577=="
MIME-Version: 1.0
Subject: Re: Review Request: Made the C++ implementaton of State return an
 Option<Variable> (rather than mutate the passed in variable via a pointer).
From: "John Sirois" <john.sirois@gmail.com>
To: "John Sirois" <john.sirois@gmail.com>
Cc: "Benjamin Hindman" <benh@berkeley.edu>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Fri, 03 Aug 2012 19:20:13 -0000
Message-ID: <20120803192013.22301.95023@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "John Sirois" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/6333/
X-Sender: "John Sirois" <noreply@reviews.apache.org>
References: <20120803062612.22301.28869@reviews.apache.org>
In-Reply-To: <20120803062612.22301.28869@reviews.apache.org>
Reply-To: "John Sirois" <john.sirois@gmail.com>

--===============9047625559266305577==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6333/#review9835
-----------------------------------------------------------

Ship it!



src/state/state.hpp
<https://reviews.apache.org/r/6333/#comment20850>

    might be good to repeat the TODO


- John Sirois


On Aug. 3, 2012, 6:26 a.m., Benjamin Hindman wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6333/
> -----------------------------------------------------------
> =

> (Updated Aug. 3, 2012, 6:26 a.m.)
> =

> =

> Review request for mesos and John Sirois.
> =

> =

> Description
> -------
> =

> See summary.
> =

> =

> Diffs
> -----
> =

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 7697589 =

>   src/java/src/org/apache/mesos/state/ZooKeeperState.java 09c4739 =

>   src/state/state.hpp e18fb16 =

>   src/tests/state_tests.cpp 9697f33 =

> =

> Diff: https://reviews.apache.org/r/6333/diff/
> =

> =

> Testing
> -------
> =

> make check
> =

> =

> Thanks,
> =

> Benjamin Hindman
> =

>


--===============9047625559266305577==--