Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 414B69245 for ; Thu, 2 Aug 2012 23:19:24 +0000 (UTC) Received: (qmail 61311 invoked by uid 500); 2 Aug 2012 23:19:24 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 61284 invoked by uid 500); 2 Aug 2012 23:19:24 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 61273 invoked by uid 99); 2 Aug 2012 23:19:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2012 23:19:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 46AE91C1942; Thu, 2 Aug 2012 23:19:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1251560974676058310==" MIME-Version: 1.0 Subject: Re: Review Request: Added a Java in-memory implementation of State. From: "Benjamin Hindman" To: "John Sirois" , "Florian Leibert" Cc: "Benjamin Hindman" , "mesos" Date: Thu, 02 Aug 2012 23:19:23 -0000 Message-ID: <20120802231923.22302.49705@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/6079/ X-Sender: "Benjamin Hindman" References: <20120802204040.22301.29362@reviews.apache.org> In-Reply-To: <20120802204040.22301.29362@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============1251560974676058310== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 2, 2012, 8:40 p.m., John Sirois wrote: > > Thanks for these reviews guys, submitting! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6079/#review9782 ----------------------------------------------------------- On Aug. 1, 2012, 4:01 p.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6079/ > ----------------------------------------------------------- > = > (Updated Aug. 1, 2012, 4:01 p.m.) > = > = > Review request for mesos, John Sirois and Florian Leibert. > = > = > Description > ------- > = > See summary. > = > = > Diffs > ----- > = > src/Makefile.am 10f1101 = > src/java/jni/org_apache_mesos_state_Variable.cpp PRE-CREATION = > src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION = > src/java/src/org/apache/mesos/state/InMemoryState.java PRE-CREATION = > src/java/src/org/apache/mesos/state/State.java PRE-CREATION = > src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION = > src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION = > src/state/state.hpp e1d9c01 = > = > Diff: https://reviews.apache.org/r/6079/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Benjamin Hindman > = > --===============1251560974676058310==--